Update DateRange.tsx #2050
Update DateRange.tsx #2050
Conversation
timeStep Prop: Control the rounding by passing a timeStep prop (e.g., 15 for 15-minute intervals). Testing: Implement unit tests outside of this file to validate the functionality and edge cases of rounding behavior. UI Considerations: The layout remains responsive and adjusts to the presence or absence of withTime.solve issue Avaiga#2034
| } | ||
| return [null, null]; | ||
| // Function to round the time based on the given step | ||
| const roundToStep = (date: Date | null, step: number | undefined): Date | null => { |
There was a problem hiding this comment.
Should go in a dateUtils.ts so that we can reuse it in dateSelector.tsx and timeSelector.tsx ...
| const roundToStep = (date: Date | null, step: number | undefined): Date | null => { | ||
| if (!date || !step) return date; | ||
| const roundedMinutes = Math.ceil(date.getMinutes() / step) * step; | ||
| return setMinutes(setHours(date, date.getHours()), roundedMinutes); |
There was a problem hiding this comment.
what happens if step = 40 and current min = 50 ?
roundedMinutes would be 80
How does DateFns handles this ?
| @@ -231,7 +218,6 @@ const DateRange = (props: DateRangeProps) => { | |||
| /> | |||
| </> | |||
| )} | |||
| {props.children} | |||
| } | ||
|
|
||
| const textFieldProps = { textField: { margin: "dense" } } as BaseDateTimePickerSlotProps<Date>; | ||
|
|
||
| const getRangeDateTime = ( |
| const dispatch = useDispatch(); | ||
| const formatConfig = useFormatConfig(); | ||
| const tz = formatConfig.timeZone; | ||
| const [value, setValue] = useState<[Date | null, Date | null]>([null, null]); | ||
| const [startProps, setStartProps] = useState<DateProps>({}); | ||
| const [endProps, setEndProps] = useState<DateProps>({}); | ||
| const module = useModule(); |
|
Are you still working on this @Aryam2121 ? |
WIthout a reply from you @Aryam2121, we'll have to close this PR ... |
|
I am updated already |
|
can you resolve the conflicts and fix the failing checks ? |
|
no activity, closing |
timeStep Prop: Control the rounding by passing a timeStep prop (e.g., 15 for 15-minute intervals).
Testing: Implement unit tests outside of this file to validate the functionality and edge cases of rounding behavior.
UI Considerations: The layout remains responsive and adjusts to the presence or absence of withTime.solve issue #1452 and old pull request changes review #2034