Skip to content

Conversation

@S-YED
Copy link

@S-YED S-YED commented Oct 9, 2024

Detailed Description of the Changes for Issue #1986

Issue Summary

The issue titled "Too much restriction on pyarrow dependency" states a breaking change in dependencies from version 3.1.1 to 4.0 due to a restriction on pyarrow. This conflict prevents the installation of packages like databricks-sql-connector==3.4.0.

Changes Made

  • File Modified: setup.py (branch: develop)

  • Dependency Updated: The version range for pyarrow has been modified to accommodate both Taipy and databricks-sql-connector dependencies.

  • Original Line:

"arrow": ["pyarrow>=17.0.0,<18.0"],
  • Updated Line:
"arrow": ["pyarrow>=14.0.1,<18.0"],

Testing

  • The changes were tested by attempting to install Taipy alongside databricks-sql-connector==3.4.0 to ensure there are no dependency conflicts:
pip install git+https://github.com/your-username/taipy.git databricks-sql-connector==3.4.0

Reference

This pull request addresses issue #1986.

Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start

],
"rdp": ["rdp>=0.8"],
"arrow": ["pyarrow>=17.0.0,<18.0"],
"arrow": ["pyarrow>=14.0.1,<18.0"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 seems a bit low to me
I thought that Databricks supports 16 but not 17
there is also an impact on the frontend...

@jrobinAV
Copy link
Member

This is related to databricks compatibility. Since we have a native integration with Databricks in taipy-enterprise, @toan-quach could you jump on this PR and the related issue?

@jrobinAV jrobinAV added 🖧 Devops Operations, monitoring, maintenance, deployment, packaging 🟧 Priority: High Must be addressed as soon dependencies Pull requests that update a dependency file Enterprise Related to an enterprise feature labels Oct 19, 2024
@toan-quach
Copy link
Contributor

@S-YED thanks for your contribution!

Seems to me that the databricks team is working on a change that will remove the upper bound for dependencies => You will be able to install taipy (even with pyarrow>=17.0.0,<18.0) after their PR is merged.
databricks/databricks-sql-python#452

However, this may take a while, so I would suggest 2 approaches:

  1. @S-YED can you taipy and databricks-sql-connector by installing them separately
pip install git+https://github.com/your-username/taipy.git
pip install databricks-sql-connector-3.4.0
  1. @jrobinAV we can expand pyarrow on our side to include 16.0 as the baseline as 16.0 is acceptable by databricks-sql-connector

@jrobinAV jrobinAV added the Core Related to Taipy Core label Oct 22, 2024
@FredLL-Avaiga
Copy link
Member

I think arrow 16+ is fine (just to be sure we'll change the version in frontend/taipy-gui/package.json too)

@toan-quach
Copy link
Contributor

toan-quach commented Oct 23, 2024

Hi @S-YED Can you help expand the version pyarrow>=16.0,<18.0?

@FredLL-Avaiga
Copy link
Member

Are you still working on this issue @S-YED ?
if you are not, please close this PR.

@S-YED S-YED closed this Oct 31, 2024
@S-YED S-YED deleted the fix-pyarrow-dependency branch October 31, 2024 17:42
@S-YED
Copy link
Author

S-YED commented Oct 31, 2024

Sorry for Closing it late, I just came back to health after several days !!
Thanks for your Update!!
@FredLL-Avaiga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Related to Taipy Core dependencies Pull requests that update a dependency file 🖧 Devops Operations, monitoring, maintenance, deployment, packaging Enterprise Related to an enterprise feature 🟧 Priority: High Must be addressed as soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants