Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all actions to be performed on a PR from external contributor #2118

Open
jrobinAV opened this issue Oct 21, 2024 · 2 comments · Fixed by #2123
Open

Allow all actions to be performed on a PR from external contributor #2118

jrobinAV opened this issue Oct 21, 2024 · 2 comments · Fixed by #2123
Labels
🖧 Devops Operations, monitoring, maintenance, deployment, packaging 💬 Discussion Requires some discussion and decision 🟨 Priority: Medium Not blocking but should be addressed 🔒 Staff only Can only be assigned to the Taipy R&D team

Comments

@jrobinAV
Copy link
Member

Some GitHub actions require specific permissions (e.g., coverage requires writing the result as a comment in the PR). These actions cannot be performed on a Pull request from an external contributor.

This is still a problem when an Avaiga member manually triggers the actions from the PR.
@jrobinAV jrobinAV added 🔒 Staff only Can only be assigned to the Taipy R&D team 🖧 Devops Operations, monitoring, maintenance, deployment, packaging 🟧 Priority: High Must be addressed as soon 🟨 Priority: Medium Not blocking but should be addressed labels Oct 21, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Oct 21, 2024
@FredLL-Avaiga FredLL-Avaiga mentioned this issue Oct 21, 2024
Merged
@FredLL-Avaiga
Copy link
Member

At least, we could not execute the job/step that we'll know will fail :-)

FredLL-Avaiga added a commit that referenced this issue Oct 22, 2024
@FredLL-Avaiga
Merge branch 'develop' into feature/#2118-do-not-calculate-coverage-o…
d376a13 
…n-external-PR
@jrobinAV jrobinAV reopened this Oct 22, 2024
@jrobinAV jrobinAV added the 💬 Discussion Requires some discussion and decision label Oct 22, 2024
@jrobinAV jrobinAV removed the 🟧 Priority: High Must be addressed as soon label Oct 22, 2024
@jrobinAV
Copy link
Member Author

I reopened it because I still want to investigate whether coverage can be checked before merging into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🖧 Devops Operations, monitoring, maintenance, deployment, packaging 💬 Discussion Requires some discussion and decision 🟨 Priority: Medium Not blocking but should be addressed 🔒 Staff only Can only be assigned to the Taipy R&D team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not calculate coverage on external PRs Avaiga/taipy
2 participants
@jrobinAV @FredLL-Avaiga