Stats: Update feature slugs for Security upsell

[a8ck3n]

Related to: #80536

Proposed Changes

Updates the array of feature slugs for the Security upsell. In this way, the upsell will still be shown if the user has a less-featured plan like basic Backups or Scan.

Why are these changes being made?

Previously a basic Scan plan would cause the Security upsell to be hidden. This was because it only declared support for the "scan" feature.

Testing Instructions

• Set up local Odyssey env: PCYsg-Pp7-p2
• Test on a site with no plans. All six upsells should be visible.
• Add a Scan plan to the site.
• Confirm the Security upsell is still visible.
• Add a Complete plan to the site.
• Confirm all upsells are hidden.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132429

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132429&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132429&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-security-upsell-features on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~104 bytes added 📈 [gzipped])

name                                                      parsed_size           gzip_size
async-load-calypso-my-sites-stats-jetpack-upsell-section       +323 B  (+2.6%)     +104 B  (+2.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[Initsogar]

Looks good to me! 👍🏽

✅ Navigated to the Stats page with a site that had no plan— all upsells were visible.
✅ Added a Scan plan— the same upsells were still visible.

✅ Tried adding a Backup plan to hide the backup upsell, just to double-check I wasn’t facing any cache issues with the previous step. 😃 The backup upsell was successfully hidden.

✅ Added a Jetpack Complete plan— all upsells were hidden as expected.

[dognose24]

I am considering a situation where the plan will remove one of these features. This approach would require updating the list to reflect the change, but it might not be easy to be aware of. 🤔 However, it would not be a blocker of this PR.

[a8ck3n]

I am considering a situation where the plan will remove one of these features. This approach would require updating the list to reflect the change, but it might not be easy to be aware of. 🤔 However, it would not be a blocker of this PR.

Yes, that's definitely an area this could be improved. The goal here was to fix the current version of the upsells based on the hard-coded listing. Two areas where this could be improved include:

1. Pulling the list of upsells from an endpoint. In that way, they could be easily updated on the server side.
2. Generating the list of feature slugs based on the individual upsells.

If we had both of these, we could remove most of the hard-coded config.