A4A > Partner Directory: Fix access control

[yashwin]

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1757

Proposed Changes

This PR fixes an issue with access control that is caused by a stale pathname. We are fixing this issue by using context.pathname that comes directly from the page router and represents the actual route being processed instead of window.locations.pathname that reflects the browser's URL bar, which might not update immediately during navigation.

Why are these changes being made?

• To fix the access control issue on Partner Directory.

Testing Instructions

• Open the A4A live link
• Go to the Overview page > Go to Partner Directory, notice the page loads as expected > Go to Overview page again > Go to Partner Directory and verify that the page loads as expected. You can reproduce this bug by following the same steps in production. You can notice in the screen recording below that the path is not updating according to the current route.

Before

Screen.Recording.2025-02-07.at.10.52.21.AM.mov

After

Screen.Recording.2025-02-07.at.10.50.59.AM.mov

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6e5559997458de15ae624a2ad9fa026f1d9f16de

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6e5559997458de15ae624a2ad9fa026f1d9f16de&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6e5559997458de15ae624a2ad9fa026f1d9f16de&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-team                     -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-sites                    -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-settings                 -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-referrals                -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-purchases                -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-plugins                  -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-partner-directory        -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-overview                 -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-migrations               -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-marketplace              -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-client                   -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies-agency-tier              -12 B  (-0.0%)       +2 B  (+0.0%)
a8c-for-agencies                          -12 B  (-0.0%)       +3 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[jkguidaven]

The fix is working as expected. LGTM 👍