Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Locations: add support for preserving geo mode in summary view #99451

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

Initsogar
Copy link
Contributor

@Initsogar Initsogar commented Feb 7, 2025

Resolves https://github.com/Automattic/jetpack-roadmap/issues/2289

Proposed Changes

  • Add support for preserving geo mode in summary view
    • Add geoMode parameter to the summary URL to maintain the selected view (Countries/Regions/Cities)
    • Update URL handling to properly read and preserve the selected tab when navigating
Before After
before.mp4
after.mp4

Why are these changes being made?

Currently, when users navigate from the Locations module to the summary view, their selected tab (Regions/Cities) is not preserved. Instead, the view defaults back to the Countries tab, creating a disjointed user experience.

These changes:

  • Preserve the user's selected view when navigating to the summary page
  • Improve navigation consistency and user experience
  • Reduce unnecessary clicks by maintaining the user's context

https://github.com/Automattic/jetpack-roadmap/issues/2289

Testing Instructions

Setup

Choose one of these options:

  • Spin up a Calypso Live Branch
  • Test on Odyssey using PCYsg-Pp7-p2
    • Note: For Odyssey, append ?flags=stats/locations to the URL

Steps to Test

  1. Navigate to the Stats page
  2. In the Locations module:
    • Switch to either the Regions or Cities tab
    • Click View all or View details to open the summary view
  3. Expected behavior:
    • The summary view should maintain your selected tab (Regions/Cities)
    • It should not default back to the Countries tab

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Initsogar Initsogar added [Feature] Stats Everything related to our analytics product at /stats/ [Status] In Progress labels Feb 7, 2025
@Initsogar Initsogar self-assigned this Feb 7, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-locations-persist-geomode on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~66 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +148 B  (+0.0%)      +66 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~18 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-calypso-my-sites-stats-summary        +32 B  (+0.1%)      +18 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Initsogar Initsogar requested review from ederrengifo and a team February 7, 2025 04:55
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 7, 2025
Copy link
Contributor

@ederrengifo ederrengifo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jwebbdev jwebbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Initsogar Initsogar merged commit 05b672b into trunk Feb 7, 2025
18 of 19 checks passed
@Initsogar Initsogar deleted the update/stats-locations-persist-geomode branch February 7, 2025 17:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants