-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats Locations: add support for preserving geo mode in summary view #99451
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~66 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~18 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves https://github.com/Automattic/jetpack-roadmap/issues/2289
Proposed Changes
geoMode
parameter to the summary URL to maintain the selected view (Countries/Regions/Cities)before.mp4
after.mp4
Why are these changes being made?
Currently, when users navigate from the Locations module to the summary view, their selected tab (Regions/Cities) is not preserved. Instead, the view defaults back to the Countries tab, creating a disjointed user experience.
These changes:
https://github.com/Automattic/jetpack-roadmap/issues/2289
Testing Instructions
Setup
Choose one of these options:
?flags=stats/locations
to the URLSteps to Test
Regions
orCities
tabView all
orView details
to open the summary viewCountries
tabPre-merge Checklist