Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable revamped domain management in production #99430

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Feb 6, 2025

Proposed Changes

  • Enabling revamped domain management in production

Why are these changes being made?

  • Domain management revamp release

Testing Instructions

  • Check that all the values are changed correctly in the intended files

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Imran92 Imran92 requested a review from a team February 6, 2025 19:00
@Imran92 Imran92 self-assigned this Feb 6, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 6, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/domain-management-revamp-production on your sandbox.

@Imran92 Imran92 merged commit 979c77d into trunk Feb 6, 2025
12 checks passed
@Imran92 Imran92 deleted the add/domain-management-revamp-production branch February 6, 2025 19:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
JessBoctor pushed a commit that referenced this pull request Mar 13, 2025
* Enable in production

* Enable domain revamp in test

* Enable at horizon

* Don't enable on horizon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants