Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: WordPress upload media mocks and alias. #99421

Merged

Conversation

jorgefilipecosta
Copy link
Member

The @wordpress/upload-media alias and mocks were added as a temporary solution because core was not properly bundling the package. But this issue was fixed upstream and meanwhile, the package versions we are using on calypso already contain the fix so these mocks are not needed.

Testing Instructions

Verify the CI is green.

@jorgefilipecosta jorgefilipecosta added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 6, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/wordpress-upload-media-alias-and-mocks on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2679 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
patterns      +8433 B  (+0.4%)    +2679 B  (+0.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2673 bytes added 📈 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-comment-block-editor                                                  +8433 B  (+0.3%)    +2679 B  (+0.4%)
async-load-automattic-global-styles-src-components-global-styles-variations      +8433 B  (+0.4%)    +2679 B  (+0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
@jorgefilipecosta jorgefilipecosta force-pushed the remove/wordpress-upload-media-alias-and-mocks branch 2 times, most recently from bb2c7d0 to 4582e85 Compare February 7, 2025 11:43
@jorgefilipecosta jorgefilipecosta merged commit 009cc12 into trunk Feb 12, 2025
13 checks passed
@jorgefilipecosta jorgefilipecosta deleted the remove/wordpress-upload-media-alias-and-mocks branch February 12, 2025 15:19
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants