Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For email actions use the same icon as in Sites #99399

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

merkushin
Copy link
Member

Related to #99287

Proposed Changes

  • For email actions use the same icon as in Sites.

Why are these changes being made?

  • This is part of the domain management revamp project.

Testing Instructions

  • Make sure you have 3 domains with different email setup: Titan, Google, Forwarding.
  • Go to http://calypso.localhost:3000/domains/manage
  • Open each domain and go to Email tab.
  • Make sure you see an updated icon (vertical three dots, each looks like a square if you zoom it in). Examples on the screenshots below.
  • Check the icons in mobile versions as well.

Screenshots

Google Titan Forwarding

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@merkushin merkushin requested a review from a team February 6, 2025 07:33
@merkushin merkushin self-assigned this Feb 6, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domain-email-action-icon on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~129 bytes removed 📉 [gzipped])

name     parsed_size           gzip_size
hosting       -779 B  (-0.0%)     -168 B  (-0.0%)
domains       -779 B  (-0.0%)     -168 B  (-0.0%)
email         -398 B  (-0.0%)     -129 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@m1r0
Copy link
Member

m1r0 commented Feb 6, 2025

Is this one ready for review @merkushin?

@merkushin merkushin marked this pull request as ready for review February 6, 2025 16:39
@merkushin merkushin requested a review from a team as a code owner February 6, 2025 16:39
@merkushin
Copy link
Member Author

@m1r0

Is this one ready for review @merkushin?

Yes, I was waiting for checks to pass 😅

Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks the same as /sites. 👍

@merkushin merkushin merged commit 1d390d8 into trunk Feb 7, 2025
17 checks passed
@merkushin merkushin deleted the update/domain-email-action-icon branch February 7, 2025 17:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFT-Untangling: Use the core three dot icon for email lists action menu
3 participants