-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: reader
and account
flows set Reader as the user's default landing page
#99379
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~273 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1362 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
reader
and account
flows set Reader as the user's default landing page
postCompleteCallback: async ( { dispatch } ) => { | ||
dispatch( | ||
savePreference( READER_AS_LANDING_PAGE_PREFERENCE, { | ||
useReaderAsLandingPage: true, | ||
updatedAt: Date.now(), | ||
} ) | ||
); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the best place for this, but I'm struggling to find another place to put this after the user has been created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to https://github.com/Automattic/loop/issues/341
Proposed Changes
/start/reader/user-social
or/start/account/user-social
Why are these changes being made?
Testing Instructions
/start/reader/user-social
/me/account
, you'll see your "Default Landing Page" is set to "The Reader"/start/account/user-social
Creating an account from this flow should also set your "Default Landing Page" to "The Reader"Pre-merge Checklist