Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink Big Sky beta label and make use of partial translations #99145

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Jan 31, 2025

Fixes #99146

Proposed Changes

Adjusts size of the BETA label to match mockups

CleanShot 2025-01-31 at 18 18 19@2x

Also attempts to make use of some existing translations if they exist.
You can see that "Create with AI" and "Create with AI {{small}}(BETA){{/small}}" are already in the process of being translated.
https://translate.wordpress.com/projects/wpcom/es/default?filters%5Bterm%5D=Create+with+AI

Why are these changes being made?

Testing Instructions

  • calypso.localhost:3000/setup/onboarding and choose Big Sky compatible goals.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@p-jackson p-jackson self-assigned this Jan 31, 2025
@p-jackson p-jackson requested a review from a team January 31, 2025 05:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@p-jackson p-jackson merged commit 166d9e6 into trunk Jan 31, 2025
13 checks passed
@p-jackson p-jackson deleted the update/adjust-big-sky-beta-label branch January 31, 2025 07:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 31, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220596

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @p-jackson for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Adjust size of beta label to match mockups
3 participants