Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: navigate by full periods #99140

Merged
merged 5 commits into from
Feb 2, 2025
Merged

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Jan 31, 2025

Related to https://github.com/Automattic/jetpack-roadmap/issues/2181 - Partial fix

Proposed Changes

  • Navigate by full periods - year, month whenever possible

Why are these changes being made?

  • Enhancement

Testing Instructions

  • Open Calypso Live
  • Choose Month to date
  • Click arrows to change date range
  • Ensure it changes back/forward by full month
  • Try with Year to date
  • Ensure similar behaviour by only by years
Screen.Recording.2025-01-31.at.4.41.14.PM.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kangzj kangzj changed the title navigate by full periods Stats: navigate by full periods Jan 31, 2025
@kangzj kangzj requested review from dognose24 and a8ck3n and removed request for dognose24 January 31, 2025 02:14
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@kangzj kangzj requested review from dognose24 and a team January 31, 2025 02:14
@kangzj kangzj self-assigned this Jan 31, 2025
@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Jan 31, 2025
@kangzj kangzj marked this pull request as ready for review January 31, 2025 02:14
@matticbot
Copy link
Contributor

matticbot commented Jan 31, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~222 bytes added 📈 [gzipped])

name                            parsed_size           gzip_size
stats                                +871 B  (+0.1%)     +187 B  (+0.1%)
plugins                               +55 B  (+0.0%)      +19 B  (+0.0%)
media                                 +55 B  (+0.0%)      +19 B  (+0.0%)
jetpack-cloud-agency-dashboard        +55 B  (+0.0%)      +16 B  (+0.0%)
backup                                +55 B  (+0.0%)      +16 B  (+0.0%)
activity                              +55 B  (+0.0%)      +16 B  (+0.0%)
a8c-for-agencies-sites                +55 B  (+0.0%)      +16 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~206 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-store-app-store-stats-listview               +871 B  (+0.7%)     +187 B  (+0.6%)
async-load-store-app-store-stats                        +871 B  (+0.3%)     +187 B  (+0.3%)
async-load-design-playground                             +55 B  (+0.0%)      +19 B  (+0.0%)
async-load-design-blocks                                 +55 B  (+0.0%)      +19 B  (+0.0%)
async-load-design                                        +55 B  (+0.0%)      +19 B  (+0.0%)
async-load-calypso-post-editor-media-modal               +55 B  (+0.0%)      +19 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal        +55 B  (+0.0%)      +19 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Jan 31, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/full-period-support-arrow-nav on your sandbox.

@@ -246,7 +320,8 @@ class StatsPeriodNavigation extends PureComponent {
momentSiteZone,
'day'
);
const showArrowsForDateRange = showArrows && dateRange?.daysInRange <= 31;
// Make sure we only show arrows for date ranges that are less than 3 years for performance reasons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a8ck3n a8ck3n mentioned this pull request Jan 31, 2025
8 tasks
Copy link
Contributor

@a8ck3n a8ck3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing for one specific case for me. If I select year-to-date and the date is Jan 31st, the previous arrow will navigate to Dec (previous month) instead of to 2024 (previous year). I'm thinking this bug would only surface on Jan 31 of any given year though.

@kangzj kangzj force-pushed the update/full-period-support-arrow-nav branch from 079fc8c to 0bb10c5 Compare February 2, 2025 20:52
@kangzj
Copy link
Contributor Author

kangzj commented Feb 2, 2025

This is failing for one specific case for me. If I select year-to-date and the date is Jan 31st, the previous arrow will navigate to Dec (previous month) instead of to 2024 (previous year). I'm thinking this bug would only surface on Jan 31 of any given year though.

Nice catch! When I tested, it worked. I think it's a problem for how today is compared... again...

Fitted in another fix for momentSiteZone and hopefully this time it will resolve all the related issues around timezones.

@kangzj kangzj merged commit 6b54b03 into trunk Feb 2, 2025
13 checks passed
@kangzj kangzj deleted the update/full-period-support-arrow-nav branch February 2, 2025 21:11
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants