Skip to content

Jetpack Cloud: fix subscriber data view email alignment #99134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

holdercp
Copy link
Contributor

@holdercp holdercp commented Jan 30, 2025

Fixes Automattic/loop#370

Proposed Changes

Before After
Screenshot 2025-01-30 at 4 24 55 PM Screenshot 2025-01-30 at 4 24 28 PM

Why are these changes being made?

  • Polish up subscriber data views

Testing Instructions

  • On Jetpack Cloud, navigate to Subscribers
  • Populate your subscribers list with wpcom accounts so both an email and name are displayed
  • The email field should be left aligned
  • To truly test this make sure the email is shorter than the name to force the text alignment to have an effect
    • You can do this by editing the email in your browser dev tools to something shorter if you need to

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@holdercp holdercp self-assigned this Jan 30, 2025
@holdercp holdercp force-pushed the fix/jpc-subscriber-data-view-alignment branch from 6029c29 to 4d2a17f Compare January 30, 2025 22:34
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@holdercp holdercp marked this pull request as ready for review January 30, 2025 22:41
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/jpc-subscriber-data-view-alignment on your sandbox.

Copy link
Contributor

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screenshot 2025-01-30 at 5 25 27 PM

@holdercp holdercp merged commit 1bbd6f9 into trunk Jan 31, 2025
13 checks passed
@holdercp holdercp deleted the fix/jpc-subscriber-data-view-alignment branch January 31, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants