-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to change their minds about Big Sky on the plans page #99128
Allow users to change their minds about Big Sky on the plans page #99128
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~10 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~14038 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~192 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense! I'll investigate how to do that. |
We'll still have one more variation. Context: p1738269257951999/1738217832.782999-slack-C085HCWCEDN |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220109 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @paulopmt1 for including a screenshot in the description! This is really helpful for our translators. |
e8bfedf
to
34d7c76
Compare
@isatuncman-auto @fditrapani The free plan modals are in this PR. |
…IS_REQUIRED_DIALOG Changes needed to be made to the useModalResolutionCallback hook anyway to ensure the dialog appeared when the user had a free domain. So switching to the PAID_PLAN_IS_REQUIRED_DIALOG dialog was better for us anyway, since it doesn't include the green "free for a year" text that sometimes appears.
f51f817
to
0f84a69
Compare
This PR doesn't include any feature flag or experiment assignment checks, so I was able to rebase onto |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220109 Thank you @paulopmt1 for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Related to #99085
Proposed Changes
Plan page Header changes
Modal changes
Start with a free plan
: Will show this modal:Start with a free plan
: Will show this modal:Testing Instructions
Start with a free plan
Continue with a free plan
Screen.Recording.2025-01-30.at.16.30.12.mov
Pre-merge Checklist