Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: add subdivisions tooltip #99119

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Stats: add subdivisions tooltip #99119

merged 1 commit into from
Jan 31, 2025

Conversation

myhro
Copy link
Contributor

@myhro myhro commented Jan 30, 2025

Closes Automattic/jetpack-roadmap#2214.

Proposed Changes

  • Add tooltip specifying the source for countries subdivisions.

Why are these changes being made?

  • (p1HpG7-rpL-p2)

Testing Instructions

  • Access the Calypso Live preview linked below.
  • Go to the locations/summary page, like /stats/day/locations/jetpack.com
  • Ensure there's a tooltip right beside the country filter dropdown for both Regions and Cities.
Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~127 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +522 B  (+0.0%)     +127 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

const divisionsTooltip = (
<StatsInfoArea>
{ translate(
'Countries and their subdivisions are based on {{link}}ISO 3166{{/link}} standards.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design contains an underscore in the ISO_3166 link, but I've dropped it since the actual source uses spaces instead.

/>
) }
</>
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've extracted this element to avoid stacking multiple props/components in the inline declaration, but I can move it back if preferable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible to me! 👍

@myhro myhro added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 30, 2025
@myhro myhro requested review from Initsogar and a team January 30, 2025 18:27
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/stats-subdivisions-tooltip on your sandbox.

Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@myhro myhro merged commit a51cfd8 into trunk Jan 31, 2025
17 checks passed
@myhro myhro deleted the add/stats-subdivisions-tooltip branch January 31, 2025 12:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 31, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17221088

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @myhro for including a screenshot in the description! This is really helpful for our translators.

paulopmt1 pushed a commit that referenced this pull request Feb 1, 2025
@a8ci18n
Copy link

a8ci18n commented Feb 4, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants