Remove Is Reskinned Flag: Remove from user and notice sections

[ddc22]

• Related to: Signup: Deprecate the concept of reskinned flows. #95419

Proposed Changes

• The lion share of changes belong to the Notice component which has usage across the codebase
• There was a minor flag in user step related components as well

Notice

Before	After

Why are these changes being made?

• Cleanup isReskinned flag

Testing Instructions

• Go to: /subscribers/<site-slug> try to add subscribers and make sure the notices work
• Check notices in other locations where applicable
• In an incognito window reach the user step and make sure everything works well

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131714

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131714&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131714&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~49 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-stepper              -84 B  (-0.0%)      -21 B  (-0.0%)
entry-subscriptions        -33 B  (-0.0%)      -12 B  (-0.0%)
entry-login                -33 B  (-0.0%)      -14 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~683 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
jetpack-connect                       -454 B  (-0.0%)     -148 B  (-0.0%)
accept-invite                         -454 B  (-0.2%)     -142 B  (-0.3%)
update-design-flow                    -123 B  (-0.0%)      -29 B  (-0.0%)
plugins                               -123 B  (-0.0%)      -32 B  (-0.0%)
plans                                 -123 B  (-0.0%)      -29 B  (-0.0%)
link-in-bio-tld-flow                  -123 B  (-0.0%)      -29 B  (-0.0%)
jetpack-app                           -123 B  (-0.0%)      -30 B  (-0.0%)
signup                                -117 B  (-0.0%)      -15 B  (-0.0%)
subscribers                            -93 B  (-0.0%)      -21 B  (-0.0%)
promote-post-i2                        -93 B  (-0.0%)      -16 B  (-0.0%)
import-hosted-site-flow                -48 B  (-0.0%)      -20 B  (-0.0%)
write-flow                             -33 B  (-0.0%)      -11 B  (-0.0%)
themes                                 -33 B  (-0.0%)      -10 B  (-0.0%)
theme                                  -33 B  (-0.0%)      -10 B  (-0.0%)
stepper-user-step                      -33 B  (-0.0%)      -18 B  (-0.0%)
stats                                  -33 B  (-0.0%)      -11 B  (-0.0%)
staging-site                           -33 B  (-0.0%)      -15 B  (-0.0%)
site-tools                             -33 B  (-0.0%)      -15 B  (-0.0%)
site-settings                          -33 B  (-0.0%)       -9 B  (-0.0%)
site-purchases                         -33 B  (-0.0%)      -13 B  (-0.0%)
site-overview                          -33 B  (-0.0%)      -16 B  (-0.0%)
site-marketing                         -33 B  (-0.0%)      -12 B  (-0.0%)
site-blocks                            -33 B  (-0.0%)      -15 B  (-0.0%)
settings-writing                       -33 B  (-0.0%)      -10 B  (-0.0%)
settings-security                      -33 B  (-0.0%)      -12 B  (-0.0%)
settings-reading                       -33 B  (-0.0%)      -11 B  (-0.0%)
settings-podcast                       -33 B  (-0.0%)      -11 B  (-0.0%)
settings-performance                   -33 B  (-0.0%)       -8 B  (-0.0%)
settings-jetpack                       -33 B  (-0.0%)      -10 B  (-0.0%)
settings-discussion                    -33 B  (-0.0%)       -9 B  (-0.0%)
settings                               -33 B  (-0.0%)       -9 B  (-0.0%)
security                               -33 B  (-0.0%)      -15 B  (-0.0%)
scan                                   -33 B  (-0.0%)      -14 B  (-0.0%)
purchases                              -33 B  (-0.0%)      -15 B  (-0.0%)
purchase-product                       -33 B  (-0.0%)      -14 B  (-0.0%)
privacy                                -33 B  (-0.0%)      -15 B  (-0.0%)
posts-custom                           -33 B  (-0.0%)      -13 B  (-0.0%)
posts                                  -33 B  (-0.0%)      -13 B  (-0.0%)
people                                 -33 B  (-0.0%)       -9 B  (-0.0%)
pages                                  -33 B  (-0.0%)      -11 B  (-0.0%)
notification-settings                  -33 B  (-0.0%)      -15 B  (-0.0%)
newsletter-post-setup-flow             -33 B  (-0.0%)      -13 B  (-0.0%)
migrate                                -33 B  (-0.0%)      -12 B  (-0.0%)
media                                  -33 B  (-0.0%)       -9 B  (-0.0%)
me                                     -33 B  (-0.0%)      -15 B  (-0.0%)
marketplace                            -33 B  (-0.0%)      -12 B  (-0.0%)
marketing                              -33 B  (-0.0%)      -12 B  (-0.0%)
link-in-bio-post-setup-flow            -33 B  (-0.0%)      -13 B  (-0.0%)
jetpack-social                         -33 B  (-0.0%)      -14 B  (-0.0%)
jetpack-search                         -33 B  (-0.0%)      -14 B  (-0.0%)
jetpack-cloud-plugin-management        -33 B  (-0.0%)      -12 B  (-0.0%)
jetpack-cloud-partner-portal           -33 B  (-0.0%)       -9 B  (-0.0%)
jetpack-cloud-agency-dashboard         -33 B  (-0.0%)       -9 B  (-0.0%)
import                                 -33 B  (-0.0%)      -15 B  (-0.0%)
hosting-features                       -33 B  (-0.0%)      -11 B  (-0.0%)
hosting                                -33 B  (-0.0%)      -15 B  (-0.0%)
home                                   -33 B  (-0.0%)       -9 B  (-0.0%)
help                                   -33 B  (-0.0%)      -15 B  (-0.0%)
google-my-business                     -33 B  (-0.0%)      -10 B  (-0.0%)
github-deployments                     -33 B  (-0.0%)      -10 B  (-0.0%)
export                                 -33 B  (-0.0%)      -11 B  (-0.0%)
email                                  -33 B  (-0.0%)       -8 B  (-0.0%)
earn                                   -33 B  (-0.0%)      -11 B  (-0.0%)
domains                                -33 B  (-0.0%)       -8 B  (-0.0%)
domain-connect-authorize               -33 B  (-0.2%)      -11 B  (-0.2%)
developer                              -33 B  (-0.0%)      -15 B  (-0.0%)
copy-site-flow                         -33 B  (-0.0%)       -5 B  (-0.0%)
concierge                              -33 B  (-0.0%)      -15 B  (-0.0%)
comments                               -33 B  (-0.0%)       -9 B  (-0.0%)
checkout                               -33 B  (-0.0%)      -14 B  (-0.0%)
build-flow                             -33 B  (-0.0%)      -10 B  (-0.0%)
backup                                 -33 B  (-0.0%)      -14 B  (-0.0%)
add-ons                                -33 B  (-0.0%)      -12 B  (-0.0%)
activity                               -33 B  (-0.0%)      -13 B  (-0.0%)
account-close                          -33 B  (-0.0%)      -15 B  (-0.0%)
account                                -33 B  (-0.0%)      -15 B  (-0.0%)
a8c-for-agencies-sites                 -33 B  (-0.0%)      -14 B  (-0.0%)
a8c-for-agencies-plugins               -33 B  (-0.0%)      -12 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~323 bytes removed 📉 [gzipped])

name                                                      parsed_size           gzip_size
async-load-signup-steps-user                                   -494 B  (-0.2%)     -167 B  (-0.2%)
async-load-signup-steps-plans-theme-preselected                 -90 B  (-0.0%)      -20 B  (-0.0%)
async-load-signup-steps-plans                                   -90 B  (-0.0%)      -20 B  (-0.0%)
async-load-signup-steps-design-picker                           -45 B  (-0.0%)      -28 B  (-0.1%)
async-load-store-app-store-stats                                -33 B  (-0.0%)      -10 B  (-0.0%)
async-load-design-playground                                    -33 B  (-0.0%)      -12 B  (-0.0%)
async-load-design-blocks                                        -33 B  (-0.0%)      -13 B  (-0.0%)
async-load-design                                               -33 B  (-0.0%)      -12 B  (-0.0%)
async-load-calypso-post-editor-editor-media-modal               -33 B  (-0.0%)       -9 B  (-0.0%)
async-load-calypso-my-sites-current-site-notice                 -33 B  (-0.1%)      -12 B  (-0.1%)
async-load-calypso-my-sites-current-site-domain-warnings        -33 B  (-0.1%)      -12 B  (-0.2%)
async-load-calypso-my-sites-checkout-modal                      -33 B  (-0.0%)      -14 B  (-0.0%)
async-load-calypso-lib-account-settings-helper                  -33 B  (-0.0%)      -15 B  (-0.0%)
async-load-calypso-components-global-notices                    -33 B  (-0.3%)      -11 B  (-0.3%)
async-load-calypso-blocks-editor-checkout-modal                 -33 B  (-0.0%)      -14 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/remove-is-reskinned-from-notice-user-sections on your sandbox.

[ddc22]

Merging this for now happy to rework any issues.