Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Send from query param to the Atomic transfer API to be set on the back end #98938

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Jan 27, 2025

Related to #98937

Proposed Changes

Why are these changes being made?

  • paYKcK-5KE-p2

Testing Instructions

  • Sandbox public-api.wordpress.com
  • Switch to this PR/use calypso.live
  • Go through the migration flow from start: choose Import or Migrate at the goals step, put in your external WordPress test site URL, choose Migrate, choose Do it myself, upgrade/checkout.
  • Grab the site ID for the test site you've created.
  • Via wpsh on your sandbox, check the value of migration_source_site_domain for your new test site ID:
> switch_to_blog( $test_site_id );
> echo get_option( 'migration_source_site_domain' );
  • The returned value should be the URL you input when you went through the migration flow.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sixhours sixhours requested a review from a team January 27, 2025 16:15
@sixhours sixhours self-assigned this Jan 27, 2025
@sixhours sixhours requested a review from a team as a code owner January 27, 2025 16:15
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 27, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 27, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
site-migration-flow               +22 B  (+0.0%)       +6 B  (+0.0%)
hosted-site-migration-flow        +22 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Jan 27, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/from-param-to-flow on your sandbox.

@alshakero alshakero removed the request for review from a team January 27, 2025 17:22
@sixhours sixhours force-pushed the add/from-param-to-flow branch from 2f68f4f to 98c5ab5 Compare January 27, 2025 21:57
@sixhours sixhours force-pushed the add/from-param-to-flow branch from 98c5ab5 to 51fa1d3 Compare January 28, 2025 18:56
@sixhours sixhours changed the title DO NOT MERGE: Site Migration: Send from query param to the Atomic transfer API to be set on the back end Site Migration: Send from query param to the Atomic transfer API to be set on the back end Jan 28, 2025
@andres-blanco
Copy link
Contributor

@sixhours this didn't work for me. I got to this screen
image
by navigating in the calypso.live from this PR. This is what I see on my sandbox
image

Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clearing the cache (by opening network tools) the change started taking effect. I can now see the option being set correctly.

@sixhours sixhours merged commit 31b2ec8 into trunk Jan 30, 2025
18 checks passed
@sixhours sixhours deleted the add/from-param-to-flow branch January 30, 2025 17:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@sixhours sixhours restored the add/from-param-to-flow branch January 30, 2025 20:35
@sixhours sixhours deleted the add/from-param-to-flow branch February 6, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hosted Site Migration: DYF Instructions is not showing direct links to the plugin installation
3 participants