Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect admin interface from default to classic style #98664

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

madhusudhand
Copy link
Contributor

@madhusudhand madhusudhand commented Jan 21, 2025

Related to #98193

🚨 DO NOT MERGE 🚨
Depends on: Automattic/jetpack#40913

Proposed Changes

  • Redirect admin interface from default to classic style when the experiment calypso_post_onboarding_holdout_120924 is enabled.

Testing Instructions

  • Visit default view of the general settings page https://wordpress.com/settings/general/:site
  • It should load calypso view (the below experiment is not enabled.)
  • Assign yourself to the experiment calypso_post_onboarding_holdout_120924
  • Visit the same page again. Now it should redirect to /wp-admin/options-general.php
  • test the same for following settings pages
    • reading
    • writing
    • discussions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@madhusudhand madhusudhand force-pushed the redirect/default-to-classic-interface branch from a9b7028 to c1eeccd Compare January 21, 2025 12:23
@matticbot
Copy link
Contributor

matticbot commented Jan 21, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~39 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
settings-discussion        +35 B  (+0.0%)      +11 B  (+0.0%)
settings-writing           +32 B  (+0.0%)       +8 B  (+0.0%)
settings-reading           +32 B  (+0.0%)      +11 B  (+0.0%)
settings                   +32 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@madhusudhand madhusudhand force-pushed the redirect/default-to-classic-interface branch from 79bf79b to 9f19b49 Compare January 21, 2025 12:44
@madhusudhand madhusudhand force-pushed the redirect/default-to-classic-interface branch from 9f19b49 to 63ac0fd Compare January 22, 2025 05:56
@madhusudhand madhusudhand requested a review from mmtr January 22, 2025 06:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 22, 2025
@madhusudhand madhusudhand requested a review from a team January 22, 2025 06:35
@madhusudhand madhusudhand marked this pull request as ready for review January 22, 2025 06:35
@mmtr
Copy link
Member

mmtr commented Jan 22, 2025

the experiment calypso_post_onboarding_holdout_120924

Heads-up that the experiment recently changed to calypso_post_onboarding_holdout_160125, we no longer use the calypso_post_onboarding_holdout_120924 one since it had to be disabled.

@lsl
Copy link
Contributor

lsl commented Jan 22, 2025

Heads-up that the experiment recently changed to calypso_post_onboarding_holdout_160125, we no longer use the calypso_post_onboarding_holdout_120924 one since it had to be disabled.

Thanks, we'll patch this before deploying. Adding DO NOT MERGE label to note that we need to also merge Automattic/jetpack#40913 at the same-ish time as well as a few things before these.

@mmtr
Copy link
Member

mmtr commented Jan 23, 2025

we'll patch this before deploying

No need to patch anything in the code, it already uses the correct experiment :) My comment was just referring to the experiment mentioned in the PR summary and testing instructions, so if you strictly follow them, you won't be able to test this PR.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug redirect/default-to-classic-interface on your sandbox.

@lsl lsl changed the base branch from trunk to add/hosting-menu-site-setting January 31, 2025 04:46
@lsl lsl changed the base branch from add/hosting-menu-site-setting to trunk January 31, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants