Remove/legacy goals holdout

[p-jackson]

Related to #

Proposed Changes

• Remove calypso_onboarding_goals_holdout_20241126 experiment check from signup
• Remove design-picker/goal-centric feature flag
• calypso_signup_unified_design_select_category tracks event no longer sent (it was associated with single-select domain picker)
• Design picker in onboarding is now always multi-select
• Site setup flow now always skips the Write and Sell steps

Why are these changes being made?

Removes deprecated logic which is no longer part of the onboarding flow now that this longterm holdout is wrapped up.

p1736477257802199-slack-C085HCWCEDN

Testing Instructions

• Test using /setup/onboarding
• Users in the control group of 22138-explat-experiment no longer see the Write/Sell mini-flows, regardless of the goal they select
• Users in the control group (in fact all users) should now see the multi-select version of the design picker

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130272

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130272&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130272&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/legacy-goals-holdout on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~201 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
site-setup-wg         -678 B  (-0.2%)     -201 B  (-0.2%)
site-setup-flow       -678 B  (-0.2%)     -201 B  (-0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[candy02058912]

Changes LGTM 👍
✅ The write/sell mini flow isn't showing up any more regardless of how I assign myself to the experiment groups.
✅ The design picker is the multi-select one

[taipeicoder]

@p-jackson I think this got added back by accident 😅

[p-jackson]

Ya 😅 I removed it again #98622 😁

[taipeicoder]

Sorry, I missed that!