Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove e2e tests for post visibility #90207

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

olaseni
Copy link
Contributor

@olaseni olaseni commented May 2, 2024

Fixes failing e2e tests that arose as a result of the post visibility component that was removed in this PR ( commit ).

@olaseni olaseni self-assigned this May 2, 2024
@olaseni olaseni requested a review from ntsekouras May 2, 2024 11:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 2, 2024
@olaseni
Copy link
Contributor Author

olaseni commented May 2, 2024

Pinging @ntsekouras because you put out the origin PR. Would it be appropriate to remove this test? Are there plans to migrate them instead since as mentioned here, the UI is being moved elsewhere.

@olaseni olaseni requested review from a team and stephanethomas and removed request for a team May 2, 2024 11:22
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ntsekouras
Copy link
Member

Pinging @ntsekouras because you put out the origin PR. Would it be appropriate to remove this test? Are there plans to migrate them instead since as mentioned WordPress/gutenberg#60456 (comment), the UI is being moved elsewhere.

Now we are using the new Post Status dialog to explicitly handle the post status. So you could either remove these tests or update them to test whatever, but using the the new component. For example in order to set a password, you can do it through the Post Status component.

Copy link
Contributor

@stephanethomas stephanethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm going to approve that pull request - I'll let you decide if it's better to remove those tests rather than updating them as Nik mentioned it.

@olaseni
Copy link
Contributor Author

olaseni commented May 6, 2024

There old UI is so far off from the new UI that the effort it takes to have tests that work across both versions is considerable. I'm going to go ahead with my initial decision to remove the tests and them introduce them after the upgrade.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix-failing-post-visibility-tests on your sandbox.

@olaseni olaseni merged commit 56ba1b4 into trunk May 6, 2024
11 checks passed
@olaseni olaseni deleted the fix-failing-post-visibility-tests branch May 6, 2024 12:41
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants