Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog onboarding: fix plan step width #77594

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Blog onboarding: fix plan step width #77594

merged 2 commits into from
Jun 1, 2023

Conversation

candy02058912
Copy link
Contributor

@candy02058912 candy02058912 commented May 31, 2023 •
edited
Loading

Fixes https://github.com/Automattic/dotcom-forge/issues/2592

Proposed Changes

Before

Plans Grid

before

Comparison chart

before

After

Plans Grid

plans.4.cols.mp4

Comparison chart

comparison.mp4

Testing Instructions

  • Checkout to this branch
  • Go through /setup/start-writing or /setup/design-first with a new account or account with 0 sites
  • At the select plan step, verify the layout

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you checked for TypeScript, React or other console errors?

@candy02058912 candy02058912 requested a review from a team May 31, 2023 08:45
@candy02058912 candy02058912 requested a review from a team as a code owner May 31, 2023 08:45
@candy02058912 candy02058912 requested a review from jeyip May 31, 2023 08:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 31, 2023
@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-68599
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-68599&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

paulopmt1
paulopmt1 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved! Now it feels better and the old plans screen still works as expected!

lupus2k
lupus2k approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@lupus2k lupus2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@candy02058912 candy02058912 merged commit 31bee99 into trunk Jun 1, 2023
@candy02058912 candy02058912 deleted the fix/blog-onboarding-plans-layout branch June 1, 2023 04:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupus2k lupus2k lupus2k approved these changes

@paulopmt1 paulopmt1 paulopmt1 approved these changes

@jeyip jeyip Awaiting requested review from jeyip jeyip was automatically assigned from Automattic/martech-decepticons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@candy02058912 @matticbot @lupus2k @paulopmt1