Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: Fix TOS URL for other locales #727

Merged
merged 1 commit into from
Nov 28, 2015
Merged

Signup: Fix TOS URL for other locales #727

merged 1 commit into from
Nov 28, 2015

Conversation

akirk
Copy link
Member

@akirk akirk commented Nov 25, 2015

Fixes #723: Signup: Localize the link to Terms of Service

Please review the list of locales and the respective URLs.

@akirk akirk added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. i18n [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Nov 25, 2015
@akirk akirk self-assigned this Nov 25, 2015
@jenial
Copy link
Contributor

jenial commented Nov 25, 2015

@akirk I am not sure the list of specific redirects is needed. This is already handled somewhere else, e.g. pt-br.wordpress.com/tos redirects to br.wordpress.com/tos, hi.wordpress.com/tos (as an example of an existing locale where we don't have localized ToS) does not change the URL but serves the English ToS page.

@drewblaisdell drewblaisdell added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 26, 2015
@akirk
Copy link
Member Author

akirk commented Nov 26, 2015

Ah, that makes it easier. Thanks, I have added that information as a comment.

drewblaisdell added a commit that referenced this pull request Nov 28, 2015
@drewblaisdell
Merge pull request #727 from Automattic/fix/i18n-tos-url
242ad02 
Signup: Fix TOS URL for other locales
@drewblaisdell drewblaisdell merged commit 242ad02 into master Nov 28, 2015
@drewblaisdell drewblaisdell deleted the fix/i18n-tos-url branch November 28, 2015 01:09
@drewblaisdell
Copy link
Contributor

Thanks @akirk.

@awaisab172 awaisab172 mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akirk akirk

Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akirk @jenial @drewblaisdell