-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework: Upgrade React to 15.3.0 #6554
Conversation
Rebased to resolve merge conflicts, upgraded to 15.2.1. Apparently React 15.3.0 is expected very soon, see facebook/react#7220. |
89669ed
to
5adca0b
Compare
Rebased again to upgrade to 15.3.0 this time. |
I ran the e2e tests on this, while eating dinner, and they passed. Also checked SSR was working for With regard to the props warnings, I'll put together a list of components that generated the warnings when hit by e2e tests. |
Maybe this is correct, and there're not that many components to fix :) $ pcregrep -M 'Found console error.*\n.*in.*created' unknownprops | sort -u | uniq
in a (created by Button)
in a (created by Card)
in button (created by Button)
in div (created by Content)
in div (created by EditorAuthor)
in div (created by ReactTransitionGroup)
in input (created by FormTextInput)
in select (created by FormSelect) |
Looks like a shorter list than I'd expected 😆 In any case, these are development warnings, and I'm fairly certain (though should confirm) they're not present in production environments. I don't really think we need necessarily address them in this pull request, as I'm sure people will (hopefully) be motivated to fix them over time to silence their consoles. What do you think? |
I have no doubt that it's inaccurate ;)
I agree. I don't think these errors should block this PR. Anyway, I've been through the |
Thanks for the review @ehg ! |
This pull request seeks to bump the minor version of React to its latest version, from 15.1.0 to 15.3.0.
While there are a number of general fixes, I'm most allured by the promise for more speeeeed (facebook/react#7005). Well, potential speed anyways.
Testing instructions:
Verify that there are no regressions in using the application from the upgrade. Examine changes included in the upgrade changelog and test against suspected use-cases that may be affected.
Your console will become very noisy as a result of this particular change:
I imagine many of these warnings are a result of applying a blanket spread of
this.props
to a DOM element. It's probably a good thing that we seek to clean these up, as I might imagine they have the potential to lead to some unexpected circumstances. In any case, it is what it is. ¯_(ツ)_/¯Test live: https://calypso.live/?branch=update/react-15-2