Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Upgrade React to 15.3.0 #6554

Merged
merged 2 commits into from
Aug 4, 2016
Merged

Framework: Upgrade React to 15.3.0 #6554

merged 2 commits into from
Aug 4, 2016

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Jul 6, 2016

This pull request seeks to bump the minor version of React to its latest version, from 15.1.0 to 15.3.0.

While there are a number of general fixes, I'm most allured by the promise for more speeeeed (facebook/react#7005). Well, potential speed anyways.

Testing instructions:

Verify that there are no regressions in using the application from the upgrade. Examine changes included in the upgrade changelog and test against suspected use-cases that may be affected.

Your console will become very noisy as a result of this particular change:

Add warning for unknown properties on DOM elements.

I imagine many of these warnings are a result of applying a blanket spread of this.props to a DOM element. It's probably a good thing that we seek to clean these up, as I might imagine they have the potential to lead to some unexpected circumstances. In any case, it is what it is. ¯_(ツ)_/¯

Test live: https://calypso.live/?branch=update/react-15-2

@aduth aduth added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 6, 2016
@aduth
Copy link
Contributor Author

aduth commented Jul 28, 2016

Rebased to resolve merge conflicts, upgraded to 15.2.1.

Apparently React 15.3.0 is expected very soon, see facebook/react#7220.

@aduth aduth changed the title Framework: Upgrade React to 15.2.0 Framework: Upgrade React to 15.2.1 Jul 28, 2016
@aduth
Copy link
Contributor Author

aduth commented Aug 3, 2016

Rebased again to upgrade to 15.3.0 this time.

@aduth aduth changed the title Framework: Upgrade React to 15.2.1 Framework: Upgrade React to 15.3.0 Aug 3, 2016
@ehg
Copy link
Member

ehg commented Aug 3, 2016

I ran the e2e tests on this, while eating dinner, and they passed. Also checked SSR was working for /theme/x. Will continue to have a play.

With regard to the props warnings, I'll put together a list of components that generated the warnings when hit by e2e tests.

@ehg
Copy link
Member

ehg commented Aug 3, 2016

I'll put together a list of components that generated the warnings when hit by e2e tests.

Maybe this is correct, and there're not that many components to fix :)

$ pcregrep -M 'Found console error.*\n.*in.*created' unknownprops | sort -u | uniq
    in a (created by Button)
    in a (created by Card)
    in button (created by Button)
    in div (created by Content)
    in div (created by EditorAuthor)
    in div (created by ReactTransitionGroup)
    in input (created by FormTextInput)
    in select (created by FormSelect)

@aduth
Copy link
Contributor Author

aduth commented Aug 4, 2016

Looks like a shorter list than I'd expected 😆

In any case, these are development warnings, and I'm fairly certain (though should confirm) they're not present in production environments. I don't really think we need necessarily address them in this pull request, as I'm sure people will (hopefully) be motivated to fix them over time to silence their consoles. What do you think?

@ehg
Copy link
Member

ehg commented Aug 4, 2016

Looks like a shorter list than I'd expected 😆

I have no doubt that it's inaccurate ;)

I don't really think we need necessarily address them in this pull request, as I'm sure people will (hopefully) be motivated to fix them over time to silence their consoles. What do you think?

I agree. I don't think these errors should block this PR.

Anyway, I've been through the CHANGELOG, and tried to break things. Can't find anything wrong so far. So I'd give this a 👍

@aduth aduth merged commit e4afa2f into master Aug 4, 2016
@aduth aduth deleted the update/react-15-2 branch August 4, 2016 14:23
@aduth
Copy link
Contributor Author

aduth commented Aug 4, 2016

Thanks for the review @ehg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants