Purchases: Fix credit card information misaligned in Manage Purchase on mobile (Fixes #200) #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umurkontaci
added
[Status] Needs Review
|
Looks good 👍
|
|
The CC info is fixed, however I noticed that "included with plan" is also broken: |
fabianapsimoes
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
| @@ -288,7 +288,7 @@ const ManagePurchase = React.createClass( { | |||
| } | |||
|
|
|||
| return ( | |||
| <span className="manage-purchase__payment-info"> | |||
| <span className="manage-purchase__detail manage-purchase__payment-info"> | |||
There was a problem hiding this comment.
I think this should only have one class, manage-purchase__detail. We can style the child by using the PaymentLogo classname.
|
Sorry, I didn't realize there was an issue for this and fixed it in #670. 😓 |
umurkontaci
force-pushed
the
fix/200-cc-misalign-on-small-screen-purchase
branch
from
ff8f95f
to
e8f8661
Compare
|
Everything about this PR is fixed in #670 and this is void now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a CSS issue where the credit card information is aligned to left on small screens.
/cc: @fabianapsimoes