tests: migrate fireEvents to userEvent where applicable

[flootr]

Changes proposed in this Pull Request

• Migrate fireEvent usages to @testing-library/user-event where applicable

Testing instructions

• Verify unit tests still pass

Related to #63409

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-34231

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-34231&env=jetpack

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[tyxla]

Beautiful, thank you ❤️

[tyxla]

Do we need this one to be async if we don't call await below?

This also raises a question: do all of those here need to be with async / await? I know it's what the library recommends, but the fact that this one passes without it makes me curious.

[flootr]

As the API userEvent provides is async (methods all return Promises) I think we should await them as the docs say.

In this case, the test passes because we test that handleProceed doesn't get called in case of a click. As we don't await the click, there may be no click happening at all which also makes the test pass. I'll add a fix and add the missing await.

[flootr]

This is a really great catch by the way 👍🏻

[tyxla]

Adding an await makes sense 👍 Thanks for the confirmation.

[jsnajdr]

Does userEvent.click really return a promise? Looking at the @testing-library/user-event internals, I see all functions return void.

When performing a DOM click, there should be nothing async inside. Internally wrapped with act(), all React updates happen synchronously.

[tyxla]

I might be missing something, but I can clearly see the click convenience function returns a Promise<void>:

https://github.com/testing-library/user-event/tree/e2a5f434b6e8b0ec0badddec52b54957b6f3320a/src/convenience/click.ts#L4

[flootr]

Release notes for v14 mention that all APIs return Promises https://github.com/testing-library/user-event/releases/tag/v14.0.0 – relevant PR is testing-library/user-event#790 (which closes testing-library/user-event#504), those might contain more in-depth information about that change.

[jsnajdr]

We are both right: we're now using version 13.5.0 which returns void, and there's version 14.0.x that started returning promises 🙂 The reason for being async is that the library supports firing sequences of events, like when typing a text, with delays between them.

[sirbrillig]

TIL about userEvent!