-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Me: Sidebar: Decode entities for User's display name on /me profile sidebar #625
Conversation
Tested, looking at code |
🚢 |
LGTM. The only feedback I have is that we should probably squash the commits here since the second commit is a fix for a whitespace issue that was introduced in the first commit. |
4685bd4
to
498b4f8
Compare
Done. Squashed. |
Me: Sidebar: Decode entities for User's display name on /me profile sidebar
Going to go ahead and merge as this solves the issue with escaping entities in the sidebar. @oskosk and I discussed different options for also escaping values that are displayed in the inputs throughout I suggested that we could potentially decode the HTML entities in the valueLink method within form-base. The only issue I see with this is that we should preferably escape as we are passing the value in to the @oskosk mentioned that he will create another PR to address the display of HTML entities within form fields. |
Display names that used a special char, for example, an ampersand were shown like & on the h2 that shows the display name under the gravatar.
It used to look like this
Now it shows just the ampersand.
cc @ebinnion