Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing: use correct wp-admin url and params #61817

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

mattwiebe
Copy link
Contributor

@mattwiebe mattwiebe commented Mar 10, 2022

Changes proposed in this Pull Request

  • Use the correct wp-admin URL and params for the site editor.

WordPress/gutenberg#38817 introduced a redirect to ensure that homepage editing works properly. Unfortunately this scrambled a lot of our (fragile!) site editor integration code on the backend.

Testing instructions

You need D76621-code on your sandbox. Sandbox a site with FSE active and also public-api.

Try to load the site editor. It should work with both prod and edge gutenberg versions. But, lacking either the backend patch, or this branch, the site editor redirects on edge to the wp-admin URL at the top level.

Related to #61776 #61858

@mattwiebe mattwiebe added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg [Goal] Full Site Editing labels Mar 10, 2022
@mattwiebe mattwiebe requested review from noahtallen and a team March 10, 2022 22:01
@mattwiebe mattwiebe self-assigned this Mar 10, 2022
@github-actions
Copy link

github-actions bot commented Mar 10, 2022

@matticbot
Copy link
Contributor

matticbot commented Mar 10, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~36 bytes removed 📉 [gzipped])

name        parsed_size           gzip_size
entry-main       -108 B  (-0.0%)      -36 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~9443 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
gutenberg-editor     +12017 B  (+2.4%)    +3909 B  (+2.5%)
themes                 -195 B  (-0.0%)     -893 B  (-0.5%)
theme                  -195 B  (-0.0%)    -1064 B  (-0.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mattwiebe mattwiebe changed the title Full Site Editing: use correct wp-admin url Full Site Editing: use correct wp-admin url and params Mar 11, 2022
@mattwiebe
Copy link
Contributor Author

mattwiebe commented Mar 11, 2022

Note that I think we need to land D76620-code first in order to get that test to pass

edit: it's landed and I force-pushed. Let's find out!

edit x2: 🎉

@mattwiebe mattwiebe merged commit 2a1de18 into trunk Mar 16, 2022
@mattwiebe mattwiebe deleted the update/site-editor-url branch March 16, 2022 15:08
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Full Site Editing [Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants