Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: Invites: Fix call to accept invite endpoint #618

Merged
merged 1 commit into from
Nov 24, 2015

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Nov 24, 2015

How to test

  • pull fix/invites-accept-invite-call
  • invite a user to a blog and get the key from the email
  • go to calypso.dev:3000/accept-invite/_blog_id_/_invite_key
  • accept the invite and confirm that everything flows

Closes #548

@lezama lezama added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. People Management labels Nov 24, 2015
@lezama lezama added this to the People Management: m6 milestone Nov 24, 2015
@lezama lezama self-assigned this Nov 24, 2015
@lezama
Copy link
Contributor Author

lezama commented Nov 24, 2015

cc @roccotripaldi and @ebinnion for review.

@roccotripaldi
Copy link
Member

Very cool! It's the first time i've actually tested the flow, and it is looking good.

  • still needs to support follower invites
  • still needs to support logged in users

I imagine we'll tackle those issues in another PR. LGTM!

@roccotripaldi roccotripaldi added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 24, 2015
lezama added a commit that referenced this pull request Nov 24, 2015
People: Invites: Fix call to accept invite endpoint
@lezama lezama merged commit 3f32227 into master Nov 24, 2015
@lezama lezama deleted the fix/invites-accept-invite-call branch November 24, 2015 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

People: Update accept invite lib to reflect endpoint changes
3 participants