Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades: record google analytics events for google-voucher. #6081

Merged
merged 1 commit into from
Jul 5, 2016

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Jun 16, 2016

Issue: #5978

Records events when the user does the google voucher flow.

Testing

Set debug with calypso:analytics.

localStorage.setItem('debug', 'calypso:analytics');

Make the google voucher flow and take a look to the console. You should see how the events are recorded:

image

cc @artpi @mtias @rralian @Essayoh

Test live: https://calypso.live/?branch=add/track-events-to-google-voucher

@retrofox retrofox added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com. labels Jun 16, 2016
@retrofox retrofox added this to the Plans: Maintenance milestone Jun 16, 2016
@lamosty
Copy link
Contributor

lamosty commented Jun 22, 2016

Nice, working for me.

selection_051

The code also looks fine.

Edit: I just noticed that one of the event names is not right — the last one. It should be ``calypso_plans_google_voucher_setup_clickbut it iscalypso_plans_google_voucher_setup_clic` instead.

@lamosty lamosty added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 22, 2016

// debounced
this.incrementStep = debounce( this.incrementStep, 300 );
this.changeStep = debounce( this.changeStep, 300 );
Copy link
Contributor

@lamosty lamosty Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it needs to be debounced? To prevent accidental double-clicks of the button?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

@retrofox retrofox force-pushed the add/track-events-to-google-voucher branch from 436f43d to 38c7ce5 Compare June 27, 2016 10:00
@retrofox
Copy link
Contributor Author

I just noticed that one of the event names is not right — the last one. It should be `calypso_plans_google_voucher_setup_click but it is calypso_plans_google_voucher_setup_clic instead.

Thanks @lamosty

@retrofox retrofox added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Jun 27, 2016
@artpi
Copy link
Contributor

artpi commented Jul 5, 2016

Works good:

calypso:analytics Recording Event ~ [Category: calypso_plans_google_voucher_generate_click] [Action: Cliked Generate Code Button] +1m

calypso:analytics Recording Event ~ [Category: calypso_plans_google_voucher_toc_accept_click] [Action: Cliked Agree Button] +3s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants