-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Picker: re-enable Reynolds design #49608
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There's still global styles / themes issues present as well. Font-preview screen … Front-end preview in Editor … Front-end … |
Related issue Automattic/themes#2971 |
Depends on Automattic/themes#3197 |
@ianstewart @scruffian 👋 I think all the known theme side issues got sorted for this to work but small things remain: Screen.Recording.2021-02-10.at.18.46.36.movThose could be issues in templates, and adjusting some button colors might help? |
Related Gutenberg issue: WordPress/gutenberg#27075 |
@ianstewart buttons are looking good in the preview at least — what do you think about re-releasing this design in the grid? |
654fdb2
to
21fdb67
Compare
@simison let's give it a shot. :) |
Needs rebase, config moved to wp-calypso/packages/design-picker/src/available-designs-config.json Lines 122 to 135 in 2e40187
I recall there were some issues on last time we looked in to this, but now it's looking good again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and font replacement works too.
21fdb67
to
5ea0e08
Compare
Changes proposed in this Pull Request
/new
onboarding flow. It was disabled in Disable "Reynolds" design in new onboarding flow #48887Testing instructions
Here's a direct test link that's easier, no need to open live-branch for testing:
https://public-api.wordpress.com/rest/v1/template/demo/rockfield/reynolds/?language=en&site_title=&font_headings=Playfair%20Display&font_base=Fira%20Sans
Depends on:
FYI @ianstewart — this PR allows easy testing of Reynolds design while it's disabled:
https://calypso.live/new/design?branch=update/re-enable-reynolds-design