-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Add analytics for sections in /purchases #475
Conversation
I'm having issues loading
|
b4e93a4
to
8dc44ab
Compare
Sorry, my mistake. It should be working now. |
@@ -35,6 +35,12 @@ const EditCardDetailsData = React.createClass( { | |||
sites: React.PropTypes.object.isRequired | |||
}, | |||
|
|||
getDefaultProps() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we ever going to override the default trackingSlug
by using the prop? If not, we should probably just store it as a property of the class and access it with this.trackingSlug
in purchasesMixin
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
Once we have #586 it needs to be rebases. Maybe we should also create utility method for analytics? |
ecef7a4
to
0fd5c71
Compare
I rebased, moved the |
LGTM 👍 (Feels weird doing that on my own PR, but none of the commits are mine) |
0fd5c71
to
41c5157
Compare
Purchases: Add analytics for sections in /purchases
Fixes #271 (well part of it)
This adds analytics calls to the single-purchase pages in
/purchases
.Testing
git checkout fix/12207-analytics
calypso:analytics
to the debugger so you see analytics calls in your consolecalypso_cancel_private_registration_purchase_view
calypso_confirm_cancel_purchase_view
calypso_cancel_purchase_view
edit_card_details_purchase_view
calypso_manage_purchase_view
calypso_edit_payment_method_purchase_view
is also included inEditPaymentMethod
in this PR, but that component doesn't appear to be linked from anywhere right now.The events should have a
product_slug
property.