Purchases: Add cancel/remove option for expired domain registrations and mappings #470

gziolo · 2015-11-23T09:03:12Z

Fixes #241.

This PR adds remove information on Manage Purchase page for purchases that are expired and can be cancelled.

Expected view:

Testing

Go to http://calypso.localhost:3000/purchases.
Selected expired domain or domain mapping purchase.
You should see remove information presented above.

gziolo · 2015-11-24T16:21:34Z

@mikeshelton1503: even when we fixed domain Cancel and Refund flow, we still se the same error message for expired domains. Let's display user message with prompt to contact support for now, and fix it in v2, what do you think? Can you provide full message text?

mikeshelton1503 · 2015-11-24T16:45:28Z

Sounds good to me. Here's the implementation for the message:

Looking to cancel? Please contact support to cancel [yourdomainname.com].

fabianapsimoes · 2015-11-24T16:59:32Z

Is it really "cancel" in this case? Or should we stick to "remove" as planned for the full feature?

mikeshelton1503 · 2015-11-24T17:15:11Z

Yes, sorry you're right, it should be:

Looking to remove this domain? Please contact support to remove [yourdomainname.com] from your account.

gziolo · 2015-11-26T08:13:15Z

@mikeshelton1503 I replace the word domain with purchase in the message displayed to the user. We need to keep in mind that this message can be displayed also for domain mapping. There is opacity filter applied on expired purchase's page:

I'm waiting for approval from your side :)

scruffian · 2015-11-26T12:51:04Z

I think we can merge this without mike's sign off given he's AFK. When he's back he can open an issue if he wants changes.

gziolo · 2015-11-26T12:58:23Z

Yes, let's do that this way.

scruffian · 2015-11-26T13:04:58Z

client/lib/purchases/index.js

+		return false;
+	}
+
+	return ( isExpired( purchase ) && purchase.isCancelable );


Why are we accessing the isCancelable property here rather than using the isCancelable function? I think that creates some confusion. I'm confused anyway!

We display only message at the moment, I think we can remove purchase.isCancelable check. I wanted to keep it similar to /my-upgrades, but as we can't cancel manually expired purchases we need to wait with this until v2.

I changed method definition to make it clearer. Commiting soon 👍

…and mappings

scruffian · 2015-11-27T14:22:33Z

client/me/purchases/manage-purchase/index.jsx

@@ -431,6 +432,32 @@ const ManagePurchase = React.createClass( {
 		}
 	},

+	renderRemovePurchaseInformation() {
+		const purchase = getPurchase( this.props ),
+			contactSupportUrl = 'https://support.wordpress.com/';


This should be https://en.support.wordpress.com/contact/

There is really no standard way, there are urls with locale and without. Both work properly. When there is no locale provided it redirects to your lang version, so in long run this seems to be better approach to let server decide which locale load.

Sorry, https://support.wordpress.com/contact/

good catch 👍

scruffian · 2015-11-27T14:55:16Z

Nice addition of 949f522.

LGTM 👍

gziolo · 2015-11-27T14:56:17Z

Thanks for help on that one @scruffian!

Purchases: Add cancel/remove option for expired domain registrations and mappings

gziolo added [Status] In Progress [Type] Task [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 23, 2015

gziolo self-assigned this Nov 23, 2015

gziolo added this to the Purchases: v1 milestone Nov 23, 2015

gziolo force-pushed the add/cancel-expired-purchases branch 3 times, most recently from 052a2af to 342fdea Compare November 23, 2015 10:13

gziolo added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Nov 26, 2015

gziolo force-pushed the add/cancel-expired-purchases branch from 36d8308 to aa9592d Compare November 26, 2015 08:14

gziolo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 26, 2015

gziolo removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Nov 26, 2015

scruffian reviewed Nov 26, 2015
View reviewed changes

scruffian added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 26, 2015

Purchases: Add cancel/remove option for expired domain registrations …

fe4465e

…and mappings

scruffian reviewed Nov 27, 2015
View reviewed changes

gziolo added 2 commits November 27, 2015 15:32

Purchases: Fix contact support url on Manage Purchase page

aa50d3f

Purchases: Add JSDoc for cancel related methods.

949f522

scruffian force-pushed the add/cancel-expired-purchases branch from d2be109 to 949f522 Compare November 27, 2015 14:54

scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 27, 2015

gziolo added a commit that referenced this pull request Nov 27, 2015

Merge pull request #470 from Automattic/add/cancel-expired-purchases

e08afcc

Purchases: Add cancel/remove option for expired domain registrations and mappings

gziolo merged commit e08afcc into master Nov 27, 2015

gziolo removed the [Status] Ready to Merge label Nov 27, 2015

gziolo deleted the add/cancel-expired-purchases branch November 27, 2015 15:04

fabianapsimoes modified the milestone: Purchases: Future Feb 25, 2016

This was referenced Oct 9, 2020

[Snyk] Security upgrade dompurify from 1.0.10 to 2.0.17 awaisab172/wp-calypso#40

Open

[Snyk] Security upgrade dompurify from 1.0.8 to 2.0.17 ajesse11x/wp-calypso#30

Open

This was referenced Apr 13, 2021

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#46

Open

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#66

Open

This was referenced Apr 27, 2021

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#72

Open

[Snyk] Fix for 2 vulnerabilities ajesse11x/wp-calypso#48

Open

ajesse11x mentioned this pull request Nov 4, 2022

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#83

Open

mdno mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities mdno/wp-calypso#113

Open

awaisab172 mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#134

Open

anarh mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities anarh/wp-calypso#102

Open

ajesse11x mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#87

Open

mdno mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities mdno/wp-calypso#119

Open

awaisab172 mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#141

Open

anarh mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities anarh/wp-calypso#108

Open

awaisab172 mentioned this pull request Oct 1, 2023

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#157

Open

ajesse11x mentioned this pull request Oct 1, 2023

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#92

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Purchases: Add cancel/remove option for expired domain registrations and mappings #470

Purchases: Add cancel/remove option for expired domain registrations and mappings #470

gziolo commented Nov 23, 2015

gziolo commented Nov 24, 2015

mikeshelton1503 commented Nov 24, 2015

fabianapsimoes commented Nov 24, 2015

mikeshelton1503 commented Nov 24, 2015

gziolo commented Nov 26, 2015

scruffian commented Nov 26, 2015

gziolo commented Nov 26, 2015

scruffian Nov 26, 2015

gziolo Nov 26, 2015

gziolo Nov 27, 2015

scruffian Nov 27, 2015

gziolo Nov 27, 2015

scruffian Nov 27, 2015

gziolo Nov 27, 2015

scruffian commented Nov 27, 2015

gziolo commented Nov 27, 2015

Purchases: Add cancel/remove option for expired domain registrations and mappings #470

Purchases: Add cancel/remove option for expired domain registrations and mappings #470

Conversation

gziolo commented Nov 23, 2015

Testing

gziolo commented Nov 24, 2015

mikeshelton1503 commented Nov 24, 2015

fabianapsimoes commented Nov 24, 2015

mikeshelton1503 commented Nov 24, 2015

gziolo commented Nov 26, 2015

scruffian commented Nov 26, 2015

gziolo commented Nov 26, 2015

scruffian Nov 26, 2015

Choose a reason for hiding this comment

gziolo Nov 26, 2015

Choose a reason for hiding this comment

gziolo Nov 27, 2015

Choose a reason for hiding this comment

scruffian Nov 27, 2015

Choose a reason for hiding this comment

gziolo Nov 27, 2015

Choose a reason for hiding this comment

scruffian Nov 27, 2015

Choose a reason for hiding this comment

gziolo Nov 27, 2015

Choose a reason for hiding this comment

scruffian commented Nov 27, 2015

gziolo commented Nov 27, 2015