Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Remove legacy test runner #4596

Merged
merged 12 commits into from
Apr 21, 2016
Merged

Test: Remove legacy test runner #4596

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
df37927
Test: Remove legacy test runner
gziolo Apr 7, 2016
5cd2ab6
Test: Improve the way npm test and make test are configured
gziolo Apr 7, 2016
77c4451
Test: Remove obsolete client/lib/auth-code-request-store Makefile
gziolo Apr 20, 2016
4812425
Test: Drop tests.json for client folder
gziolo Apr 20, 2016
0c86b0d
Test: Move missed client/components/feature-example test
gziolo Apr 20, 2016
5e27c19
Test: Move missed client/components/button-group test
gziolo Apr 21, 2016
9469729
Test: Fix Circle CI timeout for domain list test
gziolo Apr 21, 2016
70867b3
Test: Teach single test runner to split files between circle nodes
gziolo Apr 21, 2016
bb0a46c
Test: Bring back longer timeout on Circle CI and skipped tests
gziolo Apr 21, 2016
e400145
Test: Fix client/components/feature-example test
gziolo Apr 21, 2016
9efe653
Test: Remove missed `only` helper call from my-sites/plugins/plugins-…
gziolo Apr 21, 2016
507db47
Test: Update test README
gziolo Apr 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions client/components/feature-example/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ import { shallow } from 'enzyme';
import FeatureExample from '../index';

describe( 'Feature Example', function() {
it( 'should have Feature-example class', function() {
it( 'should have Feature-example class', () => {
const featureExample = shallow( <FeatureExample /> );
assert.equal( 1, featureExample.find( '.feature-example' ).length );
assert.lengthOf( featureExample.find( '.feature-example' ), 1 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected value is usually first.

Copy link
Member Author

@gziolo gziolo Apr 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, lenghtOf is tricky:

.lengthOf(object, length, [message])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I get it now – the grammar would be wrong if the length was the first argument.

} );

// TODO: fix it
it.skip( 'should contains the passed children wrapped by a feature-example div', function() {
it( 'should contains the passed children wrapped by a feature-example div', () => {
const featureExample = shallow( <FeatureExample><div>test</div></FeatureExample> );
assert.equal( true, featureExample.contains( '<div>test</div>' ) );
assert.isTrue( featureExample.contains( <div>test</div> ) );
} );
} );