Site Settings: move primary button to <SectionHeader>. #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update to use <Button>.
mtias
added
[Feature] Site Settings
|
Tested, Works. I am kinda worried that this save button is in the same place as 'close' on Windows window. |
|
The section-header buttons is a pattern that will be extended to more sections as they adopt it. It's currently used in |
|
🚢 |
artpi
added
[Status] Ready to Merge
and removed
[Status] Needs Review
mtias
added a commit
that referenced
this pull request
Nov 25, 2015
Site Settings: move primary button to <SectionHeader>.
| onClick={ this.submitForm } | ||
| primary={ true } | ||
| type="submit" | ||
| disabled={ this.state.fetchingSettings || this.state.submittingForm }> |
There was a problem hiding this comment.
Just for the next time maybe you could close the Component in the same TAB where it was opened.
<Button
compact={ true }
onClick={ this.submitForm }
primary={ true }
type="submit"
disabled={ this.state.fetchingSettings || this.state.submittingForm }
>
{ this.state.submittingForm
? this.translate( 'Saving…' )
// ...
This was referenced Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update it to use
<Button>. Part of series of iterative improvements in the site settings screens.