Plugins: Fix Plugin Banner to be more responsive and work better on desktop #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
Jetpack
Jetpack Plugins
[Feature] WordPress Desktop App
|
LGTM |
|
I added a small css tweak, give it a look over, but I think we're ready to ship. |
enejb
force-pushed
the
fix/plugin-image-full-screen
branch
from
3dbbdd7
to
544eb05
Compare
|
Thanks for the fixes Rick, I just squashed them 👍 |
enejb
added a commit
that referenced
this pull request
Nov 24, 2015
Plugins: Fix Plugin Banner to be more responsive and work better on desktop
scruffian
removed
the
[Status] Needs Review
lancewillett
removed
the
[Status] Needs Design Review
3 tasks
This was referenced Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is based on the code by the Reader since it seems to work really well there.
This is how it looks like if there is no banner
When there is a banner ( Should be the same as now )
If the width of the main div is larger then the size of the image.
To test go to a single plugins in calypso.Check that the banner looks as expected.
cc: @MichaelArestad