Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy chat closure notices #32278

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Apr 15, 2019

Removes two unused components that used to display a "chat closed" notices.

The first one is HelpContactClosed that is simply not imported anywhere. There is another component, LiveChatClosureNotice, that does the same job and is actively used.

The second one is ChatBusinessConciergeNotice which was used for an one-off experiment back in 2017 and the code was never removed. See #16144.

@hewsut inspired me to take a closer look when I was looking at his #32276 🙂

@jsnajdr jsnajdr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial Help labels Apr 15, 2019
@jsnajdr jsnajdr requested review from mhsdef, unDemian, jeremeylduvall and a team April 15, 2019 12:59
@jsnajdr jsnajdr self-assigned this Apr 15, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

name            parsed_size    gzip_size
domainsLanding         +0 B         +8 B  (+0.0%)
build                  +0 B         +8 B  (+0.0%)

Sections
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

name  parsed_size           gzip_size
help      -1769 B  (-0.2%)     -479 B  (-0.5%)

Async-loaded Components
React components that are loaded lazily, when a certain part of UI is displayed for the first time.

name                                   parsed_size           gzip_size
async-load-blocks-inline-help-popover      -2318 B  (-0.4%)     -566 B  (-1.3%)

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@mhsdef mhsdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best kind of PR, lovely. LGTM.

@jsnajdr jsnajdr merged commit 278f4c5 into master Apr 15, 2019
@jsnajdr jsnajdr deleted the remove/legacy-closure-notices branch April 15, 2019 14:26
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants