-
Notifications
You must be signed in to change notification settings - Fork 2k
Support User: Add user interface components #3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fed9a51
to
11a2fe0
Compare
@@ -119,6 +124,7 @@ Layout = React.createClass( { | |||
<div className={ sectionClass }> | |||
{ config.isEnabled( 'keyboard-shortcuts' ) ? <KeyboardShortcutsMenu /> : null } | |||
{ this.renderMasterbar() } | |||
{ config.isEnabled( 'support-user' ) ? <SupportUser /> : null } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be { config.isEnabled( 'support-user' ) && <SupportUser /> }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
I tested this a little, and it works well for me. As noted elsewhere, I do see this js error when I use the feature: "Warning: Failed propType: Invalid prop I think that's not related to this PR and that it's related to the issue reported in #3029. |
8ae0046
to
3ac1391
Compare
@mtias mind giving this another look to confirm that your suggestions are adequately addressed? |
I took another look at the code, and it looks good to me and seems that the requested changes have been made. I also gave it another test drive, and other than some known issues recorded elsewhere, it works well. Two pieces of feedback that I think we should jot down elsewhere rather than trying to piggyback on this PR:
Let's 🚢. |
3ac1391
to
315d033
Compare
The new directory placement looks good to me. |
315d033
to
a3ac6fe
Compare
I've opened #3201 for this
Currently the highlight changes at the moment the support token injection changes - meaning any API calls from that point will be injected/not injected with the token. I think delaying the change could open us up to instances where the user falsely believes they are acting without/without the support token being injected. What we could do is to place an overlay across the whole page, preventing interaction until all data has been refreshed. |
Support User: Add user interface components
This adds a keyboard shortcut and login box for the support user feature. Props to @mrheston and @jmdodd for the original work on this.
Ref p195om-2GO-p2
cc @dllh