-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FormInputValidation to G Suite Add User Field #29728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following error is throw when I access the Add G Suite User
page:
Uncaught ReferenceError: kebabCase is not defined
at eval (app:///./client/my-sites/domains/domain-management/add-google-apps/add-email-addresses-card.jsx:479)
at Array.map (<anonymous>)
at getDerivedStateFromProps (app:///./client/my-sites/domains/domain-management/add-google-apps/add-email-addresses-card.jsx:466)
at applyDerivedStateFromProps (app:///./node_modules/react-dom/cjs/react-dom.development.js:12278)
at mountClassInstance (app:///./node_modules/react-dom/cjs/react-dom.development.js:12630)
at updateClassComponent (app:///./node_modules/react-dom/cjs/react-dom.development.js:14256)
at beginWork (app:///./node_modules/react-dom/cjs/react-dom.development.js:15082)
at performUnitOfWork (app:///./node_modules/react-dom/cjs/react-dom.development.js:17820)
at workLoop (app:///./node_modules/react-dom/cjs/react-dom.development.js:17860)
at HTMLUnknownElement.callCallback (app:///./node_modules/react-dom/cjs/react-dom.development.js:149)
Unit tests are failing as well.
client/my-sites/domains/domain-management/add-google-apps/add-email-addresses-card.jsx
Outdated
Show resolved
Hide resolved
client/my-sites/domains/domain-management/add-google-apps/add-email-addresses-card.jsx
Outdated
Show resolved
Hide resolved
client/my-sites/domains/domain-management/add-google-apps/domains-select.jsx
Outdated
Show resolved
Hide resolved
4a45c74
to
744a904
Compare
98a658e
to
c935211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS needs to be fixed up so that the errors don't mess with the field widths.
c935211
to
0f51f68
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and code looks good
…ng a fixed object
…d of being a fixed object" This reverts commit 4bac1c9.
Changes proposed in this Pull Request
BEFORE
AFTER
Testing instructions
a
, and press "Continue"a&
and press "Continue"123456789123456789123456789123456789123456789123456789123456789123456789
and confirm the error message is "Please provide a valid email address.".Fixes #29696