Purchases: Update links to theme showcase #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Point to the new showcase (`/design/${ domain }`) to select a theme for a site.
* Use the `getDetailsUrl()` helper from `lib/themes` for the theme details link.
This way, the URL is guaranteed to remain correct once we re-wire that helper
to point to the new showcase.
ockham
added
[Feature Group] Appearance & Themes
|
Works well, and the code looks good. 👍 |
drewblaisdell
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks for reviewing! |
ockham
added a commit
that referenced
this pull request
Feb 2, 2016
…eme-showcase Purchases: Update links to theme showcase
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/design/${ domain }) to select a theme for a site.getDetailsUrl()helper fromlib/themesfor the theme details link.This way, the URL is guaranteed to remain correct once we re-wire that helper
to point to the new showcase.
No visual changes.
To test:
http://wordpress.com/themes/[site]/[theme]Note that I haven't yet found out how to test the changes in
client/me/purchases/cancel-purchase/product-information.jsx, since apparently I can't cancel a premium theme I purchased using free credits.CC @drew and @gziolo for review.