Plans: Reduxify Plan Remove component #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanethomas
added
[Feature] Plans & Upgrades
|
These changes look great. There are a lot though. I think it would have been better to do the Redux stuff in a different PR to the refactoring. |
|
Thanks for your feedback Ben! I agree this pull request ended up being too long. |
stephanethomas
added
[Status] Needs Review
stephanethomas
force-pushed
the
update/reduxify-plan-remove
branch
from
fa0d21a
to
147892a
Compare
| type: FETCH_SITE_PLANS, | ||
| siteId: siteId | ||
| it( 'should return an empty state when original state and action are empty', () => { | ||
| const original = Object.freeze( {} ), |
There was a problem hiding this comment.
Good idea to wrap the initial state in Object.freeze in all of these tests. 👍
drewblaisdell
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
stephanethomas
force-pushed
the
update/reduxify-plan-remove
branch
2 times, most recently
from
eec8ebf
to
1ecada0
Compare
|
I've rebased (this was lots of fun this time sic) and implemented the changes requested. This is ready for another review. |
stephanethomas
added
[Status] Needs Review
|
Changes look good. |
|
Product 👌 |
fabianapsimoes
added
[Status] Ready to Merge
and removed
[Status] Needs Review
…page This fixes an 'Uncaught TypeError: this.props.getSelectedSite is not a function' error thrown when dismissing the notice displayed upon a successful free trial cancelation.
There can be only one.
… naming convention
… naming convention
There is no need to return an action thunk here.
… about This moves from using initial site state constants to using plain objects to describe assertions. The goal is to make these unit tests easier to understand (since the expected results are obvious and don't require any interpretation of Object.assign()) and more flexible (by specifying different original states).
This also fixes the case where isFetching would not be reset in case of failure.
This makes obvious that this action expects a list of plans returned by the API - which will then be converted to a different data structure by the assembler.
This also adds the corresponding unit tests.
… Plans reducer Less is more.
This is the first step to merging this flag with the one for fetching since we don't really need to manage both states after all.
This is the last step to merging this flag with the one used previously for updating - so we only have to manage a single state.
fabianapsimoes
force-pushed
the
update/reduxify-plan-remove
branch
from
1ecada0
to
16e700e
Compare
fabianapsimoes
added a commit
that referenced
this pull request
Feb 8, 2016
Plans: Reduxify Plan Remove component
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #2626 by extracting the part that handles the API call from the
<PlanRemove />component and connecting this component to the Redux state tree. It also fixes a few things and refactors some code in the process:Fixing
Refactoring
Reduxification
<PlanRemove />componentAs a reminder the
<PlanRemove />component is responsible for displaying a new section with a link at the bottom of thePlans Overviewpage during the grace period:This link displays a modal that allows users to cancel a free trial:
Users are redirected on the
Planspage with a message if the cancelation is successful:Testing instructions
git checkout update/reduxify-plan-removeand start your serverPlan Overviewpage with a free trial in grace periodRemove nowlink and then click theRemove Nowbutton in the modalPlanspageReviews