-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Social Logo to the latest version. #2950
Conversation
Added hover styling on the dev/docs
To clarify: the naming convention for the other roundrect logos is this:
This PR just adds a roundrect twitter logo in place of the twitter.svg file (which is in accordance with the examples above), and moves what used to be twitter.svg over to twitter-alt.svg. |
Pinging @drw158 and @kellychoffman |
Do all the roundrect icons share the same border radius? |
I looked in the AI file and it seems like they’re all 2px border radius except Facebook, which is 1px. I think that’s their guideline. |
When this PR is merged, I'll be able to get #1474 past this stage (eg, with a roundrect Twitter logo): |
Yep, Facebook has a smaller border radius; the vector is straight from their brand resources. |
@kellychoffman Is the border radius a blocker for this? |
Not a blocker. 👍 Good to go. |
Code looks good to me, since it's generated in the social-logos repo. |
…tter-rect Update: Social Logo to the latest version.
Added hover styling on the dev/docs
Added Share Icon
Update twitter logo
Added twitter-alt logo.
The reason why the twitter-alt is more for consistency.
Most of the services have a box around the logo.
After:
cc @alternatekev