SSR: Only render into DOM if component tree is not already there #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used as a base for experimenting with routing/layout.
seear
added
[Feature Group] Appearance & Themes
seear
changed the title
|
Closing this, as we're currently using this technique in #3053. |
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental. Inside controller.js, only render into the DOM if the component tree is not already there. This eliminates problems with browser lockups when replacing server-rendered component trees inside the existing content divs.
As long as the initial client layout done in client/boot matches the server-layout, the necessary event-handlers will be hooked-up.
This PR uses a simple test component with a button that is rendered on the server at http://calypso.localhost:3000/design (logged-out). It adds a couple of links to the logged-out master bar to switch between logged-out routes.