Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: A/B test displaying a feature list vs. description in Plan #2924

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

drewblaisdell
Copy link
Contributor

Fixes #2752.

screen shot 2016-01-29 at 3 36 55 pm

Testing
With a description

  • Visit http://calypso.localhost:3000/start in a new browsing session.
  • Run localStorage.setItem( 'ABTests', '{"plansFeatureList_20040201":"description"}' ); in your browser.
  • Proceed through signup to the plans step.
  • Assert that you see a sentence as the description for each plan.
  • Assert that you see the same description on /plans/:site after signing up.

With a list of features

  • Visit http://calypso.localhost:3000/start in a new browsing session.
  • Run localStorage.setItem( 'ABTests', '{"plansFeatureList_20040201":"list"}' ); in your browser.
  • Proceed through signup to the plans step.
  • Assert that you see a list of features (like in the screenshot above) for each plan.
  • Assert that you see the same list of features on /plans/:site after signing up.
  • Product review
  • Code review

cc @danhauk

@drewblaisdell drewblaisdell added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task labels Jan 29, 2016
@drewblaisdell drewblaisdell self-assigned this Jan 29, 2016
@breezyskies
Copy link
Contributor

Looks good! A couple nitpicks:

  1. On the /plans page for logged in users, the "never expires" and space below looks off. I'd just hide this entirely so it looks like the signup version:

screen shot 2016-01-29 at 4 20 57 pm

  1. I'd bump the top / bottom padding on the features up to 5px.

@breezyskies breezyskies added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 30, 2016
@drewblaisdell
Copy link
Contributor Author

@breezyskies Thanks for the feedback. I updated the commit with those changes.

@drewblaisdell drewblaisdell added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Jan 30, 2016
@breezyskies
Copy link
Contributor

Looks good. 👍

@scruffian
Copy link
Member

Code 👍

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 2, 2016
@drewblaisdell
Copy link
Contributor Author

cc @lucasartoni to make sure that it's cool to run this concurrently with the periodLabelFree test.

Edit: He confirmed on Slack, so we're good-to-go here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants