Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boot: Don't render empty Layout #26944

Merged
merged 5 commits into from
Nov 5, 2018
Merged

Boot: Don't render empty Layout #26944

merged 5 commits into from
Nov 5, 2018

Commits on Nov 2, 2018

  1. Boot: Don't render empty Layout

    @ockham @jsnajdr
    ockham authored and jsnajdr committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    a115a4d View commit details
    Browse the repository at this point in the history

  2. Framework: Don't auto-inject page.js' onClick handler

    @ockham @jsnajdr
    ockham authored and jsnajdr committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    4c99b20 View commit details
    Browse the repository at this point in the history

  3. Layout: Manually add page.js' onClick handler

    @ockham @jsnajdr
    ockham authored and jsnajdr committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    1bcdcf1 View commit details
    Browse the repository at this point in the history

  4. Install the page.clickHandler on the root layout element

    @jsnajdr
    jsnajdr committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    f8fc160 View commit details
    Browse the repository at this point in the history

  5. Render empty layout for logged out home page 

    Makes e2e tests happy, should eventually be replaced with some more systematic approach
to how to handle logged-out pages and redirects to login page.
    @jsnajdr
    jsnajdr committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    e5b64d2 View commit details
    Browse the repository at this point in the history