Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAP: Disable all links & buttons that add upgrade to the cart #2523

Merged
merged 2 commits into from
Jan 19, 2016

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jan 18, 2016

It partially fixes #291.

Features covered in this PR:

  • Domains search
  • Renew button
  • Credit card list and edit

Testing

  1. Disable the following flags in the config file:
    • upgrades/checkout
    • upgrades/credit-cards
    • upgrades/domain-search
  2. Execute make run and go to http://calypso.localhost:3000/purchases.
  3. Select a Purchase that expires soon.
  4. On Manage Purchase page there should be no Renew button.
  5. You shouldn't be able to edit Credit Card details.
  6. Go to Billing History (http://calypso.localhost:3000/me/billing) and scroll to the bottom of the page.
  7. You shouldn't see list of credit cards.
  8. Go to Domain (http://calypso.localhost:3000/domains/manage).
  9. Select a Site.
  10. You shouldn't see any button that allows to add domain.
  11. Go to Site Settings (http://calypso.localhost:3000/settings/general).
  12. Select a Site.
  13. In Site Address section you shouldn't see any button or link which allows to add domain, domain mapping or site redirect.
  14. There should be no information about domain registration in Change Site Address.

Now enable flags listed in (1) and repeat all other steps, you should see all action buttons and links :)

@gziolo gziolo added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Jan 18, 2016
@gziolo gziolo self-assigned this Jan 18, 2016
@gziolo gziolo added this to the Gold: backlog milestone Jan 18, 2016
@gziolo gziolo added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Jan 18, 2016
@gziolo
Copy link
Member Author

gziolo commented Jan 19, 2016

Pinging @scruffian, @janm6k and @peterbutler for review.

@janm6k
Copy link
Contributor

janm6k commented Jan 19, 2016

I am trying to test the changes in client/my-sites/site-settings/delete-site-options/index.jsx - what do I need to have and do to see that component?

@gziolo
Copy link
Member Author

gziolo commented Jan 19, 2016

I am trying to test the changes in client/my-sites/site-settings/delete-site-options/index.jsx - what do I need to have and do to see that component?

Point (14) from the list. Yes, I know that the name of the component is a bit tricky :)

@janm6k
Copy link
Contributor

janm6k commented Jan 19, 2016

Aha :)

In that case, :shipit:

@janm6k janm6k added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 19, 2016
@gziolo gziolo force-pushed the update/purchase-feature-flags branch from 74aa1ea to be8b593 Compare January 19, 2016 12:20
gziolo added a commit that referenced this pull request Jan 19, 2016
IAP: Disable all links & buttons that add upgrade to the cart
@gziolo gziolo merged commit 8322c39 into master Jan 19, 2016
@gziolo gziolo deleted the update/purchase-feature-flags branch January 19, 2016 12:30
@@ -155,7 +166,9 @@ const ManagePurchase = React.createClass( {
cardExpiry: creditCard.expiryMoment.format( 'MMMM YYYY' )
},
components: {
a: <a href={ paths.editCardDetails( this.props.selectedSite.slug, id, creditCard.id ) } />
a: canEditPaymentDetails() ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function throws an error if it isn't passed a purchase object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans/Domains: Add a feature flag that disables payments in Calypso
3 participants