-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IAP: Disable all links & buttons that add upgrade to the cart #2523
Conversation
Pinging @scruffian, @janm6k and @peterbutler for review. |
I am trying to test the changes in |
Point (14) from the list. Yes, I know that the name of the component is a bit tricky :) |
Aha :) In that case, |
…behind feature flags
74aa1ea
to
be8b593
Compare
IAP: Disable all links & buttons that add upgrade to the cart
@@ -155,7 +166,9 @@ const ManagePurchase = React.createClass( { | |||
cardExpiry: creditCard.expiryMoment.format( 'MMMM YYYY' ) | |||
}, | |||
components: { | |||
a: <a href={ paths.editCardDetails( this.props.selectedSite.slug, id, creditCard.id ) } /> | |||
a: canEditPaymentDetails() ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function throws an error if it isn't passed a purchase
object.
It partially fixes #291.
Features covered in this PR:
Testing
upgrades/checkout
upgrades/credit-cards
upgrades/domain-search
make run
and go to http://calypso.localhost:3000/purchases.Now enable flags listed in (1) and repeat all other steps, you should see all action buttons and links :)