Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Replace LinkedStateMixin addon with standalone package #1901

Merged
merged 1 commit into from
Dec 22, 2015

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Dec 21, 2015

Related: #1498, #1878

This pull request seeks to replace all instances of React.addons.LinkedStateMixin with the standalone package react-addons-linked-state-mixin. React addons were moved to separate packages in React 0.14 and currently cause warnings to appear in development environments.

Testing instructions:

Verify that existing usage of LinkedStateMixin remain unaffected.

@aduth aduth added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 21, 2015
@lezama
Copy link
Contributor

lezama commented Dec 22, 2015

I browsed and used the forms on some of the sections involved and they seem to work, I say :shipit:

@aduth aduth added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 22, 2015
aduth added a commit that referenced this pull request Dec 22, 2015
…tate-mixin

Framework: Replace LinkedStateMixin addon with standalone package
@aduth aduth merged commit 9523377 into master Dec 22, 2015
@aduth aduth deleted the update/react-addons-linked-state-mixin branch December 22, 2015 13:12
@aduth
Copy link
Contributor Author

aduth commented Dec 22, 2015

Thanks @lezama !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants