Redux: Provide Redux store instance to Layout component
#1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordwest
added
[Type] Enhancement
| @@ -163,6 +162,7 @@ function boot() { | |||
| // Create layout instance with current user prop | |||
| Layout = require( 'layout' ); | |||
| layout = ReactDom.render( React.createElement( Layout, { | |||
| store: reduxStore, | |||
There was a problem hiding this comment.
I dont know if we really need that - we can connect components that need access to store using connect down the line.
|
Ah perfect, thanks for your work on that @artpi. Looks like it's all covered there so I'll close this for now |
scruffian
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the global Redux
storeinstance available to theLayoutcomponent. Some ofLayout's children that might want to access the Redux store in the future include:Masterbar(planned in Support User: Add SupportUser component. #1202)NoticesList(@artpi?)WelcomeMessageEmailVerificationNoticeInviteMessageThe
Layoutcontainer is wrapped in a react-reduxProvider, allowing any children to access the Redux store directly via react-reduxconnect().