Free Trials: Add expiring state to PlanStatus
#1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewblaisdell
added
[Status] Needs Review
7 tasks
drewblaisdell
force-pushed
the
add/plan-status-expiring-state
branch
from
706e00b
to
a407776
Compare
2 tasks
| @@ -37,26 +31,32 @@ const PlanStatusProgress = React.createClass( { | |||
| }, | |||
|
|
|||
| renderDaysRemaining() { | |||
| const { plan } = this.props; | |||
|
|
|||
| return this.translate( | |||
| '%(daysUntilExpiry)s day remaining', | |||
| '%(daysUntilExpiry)s days remaining', | |||
There was a problem hiding this comment.
If the daysUntilExpiry argument is always an integer we could reference it as %(daysUntilExpiry)d instead.
|
Did we really need to move the progress bar into its own folder? As far as I know it's perfectly fine to have sub-components. |
stephanethomas
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
drewblaisdell
force-pushed
the
add/plan-status-expiring-state
branch
2 times, most recently
from
46d4153
to
3235938
Compare
drewblaisdell
added
[Status] Needs Review
|
Thanks for looking, @stephanethomas. I moved |
|
Code looks good. |
|
👍 LGTM, awaiting pull 1780 for proper expiry messaging |
ghost
added
[Status] Ready to Merge
and removed
[Status] Needs Review
drewblaisdell
force-pushed
the
add/plan-status-expiring-state
branch
from
3235938
to
6304062
Compare
drewblaisdell
added a commit
that referenced
this pull request
Dec 18, 2015
Free Trials: Add expiring state to `PlanStatus`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #1151.
This PR updates the render() of
PlanStatusand its child,PlanStatusProgress, to display a red progress bar/'days remaining' text and a primary 'Purchase Now' button if the trial expires within five days.Testing
Review