-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences: Fix 2FA issues by using /me/preferences endpoint #15095
Conversation
d89a434
to
6fa49a7
Compare
Rebased |
@mcsf This PR needs a rebase |
6fa49a7
to
48468ed
Compare
I gave this a spin today (together with sandboxing the API patch) and wasn't able to fully get the new endpoint working. However, testing in the Live Branch I verified the new API call made from to |
Using the new API endpoint on the backend now works (patch updated). 👍 Testing with the live branch (and sandboxed API requests) I'm able to see a successful call to the new
|
Thanks for tackling this one. |
Thanks for looking! Removing Needs Review and adding Hold as we work on the endpoint itself. |
An endpoint for non-critical user settings that shouldn't require fresh 2FA data.
3ec8512
to
5cbd4d0
Compare
D5992-code has been deployed. This PR has been rebased and retested. Going to merge this. :) cc @aduth to keep you in the loop, as you've worked on Preferences a lot |
YES THANK YOU!!! :D |
Requires D5992-codeFixes #202 #3666
… as well as its numerous related issues.