Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences: Fix 2FA issues by using /me/preferences endpoint #15095

Merged
merged 3 commits into from
Jul 6, 2017

Conversation

mcsf
Copy link
Member

@mcsf mcsf commented Jun 14, 2017

Requires D5992-code

Fixes #202 #3666
… as well as its numerous related issues.

@mcsf mcsf self-assigned this Jun 14, 2017
@matticbot matticbot added the [Size] M Medium sized issue label Jun 14, 2017
@matticbot
Copy link
Contributor

@mcsf mcsf requested review from lancewillett, ehg and mtias June 14, 2017 10:31
@mcsf mcsf added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. State labels Jun 14, 2017
@mcsf mcsf force-pushed the update/calypso-preferences-endpoint branch from d89a434 to 6fa49a7 Compare June 19, 2017 11:52
@mcsf
Copy link
Member Author

mcsf commented Jun 19, 2017

Rebased

@matticbot
Copy link
Contributor

@mcsf This PR needs a rebase

@mcsf mcsf force-pushed the update/calypso-preferences-endpoint branch from 6fa49a7 to 48468ed Compare June 21, 2017 15:50
@lancewillett
Copy link
Contributor

I gave this a spin today (together with sandboxing the API patch) and wasn't able to fully get the new endpoint working. However, testing in the Live Branch I verified the new API call made from to /me/preferences even though it resulted in a 404. :)

@lancewillett
Copy link
Contributor

Using the new API endpoint on the backend now works (patch updated). 👍

Testing with the live branch (and sandboxed API requests) I'm able to see a successful call to the new /me/preferences endpoint from https://calypso.live/me.

GET /rest/v1.1/me/preferences?http_envelope=1 HTTP/1.1
Host: public-api.wordpress.com
URL: https://public-api.wordpress.com/rest/v1.1/me/preferences?http_envelope=1
Status code: 200 OK

@mtias
Copy link
Member

mtias commented Jun 22, 2017

Thanks for tackling this one.

@mcsf mcsf added [Status] Ready to Merge [Status] Blocked / Hold and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge labels Jun 22, 2017
@mcsf
Copy link
Member Author

mcsf commented Jun 22, 2017

Thanks for looking! Removing Needs Review and adding Hold as we work on the endpoint itself.

@mcsf mcsf force-pushed the update/calypso-preferences-endpoint branch from 3ec8512 to 5cbd4d0 Compare June 22, 2017 16:45
@mcsf
Copy link
Member Author

mcsf commented Jul 6, 2017

D5992-code has been deployed. This PR has been rebased and retested. Going to merge this. :)

cc @aduth to keep you in the loop, as you've worked on Preferences a lot

@mcsf mcsf merged commit 2b4db52 into master Jul 6, 2017
@mcsf mcsf deleted the update/calypso-preferences-endpoint branch July 6, 2017 09:29
@folletto
Copy link
Contributor

folletto commented Jul 6, 2017

YES THANK YOU!!! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants