Me: Select correct nav when password updated #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix for #399. When the password is updated, match this.props.path to 'me/security' so the Password menu item is highlighted.
jeremeylduvall
added
[Type] Bug
[Status] In Progress
[Feature] User & Account Settings (/me)
|
@jeremeylduvall - I believe the line that should've actually been updated is selected={ tab.path === this.props.path }. The original commit did work, but I believe it was only because it incorrectly mutated The second commit adds a new method called |
|
👍 Works for me. Thanks @ebinnion! |
ebinnion
added a commit
that referenced
this pull request
Dec 5, 2015
Me: Select correct nav when password updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #399. When the password is updated, match this.props.path to 'me/security' so the Password menu item is highlighted.
Here's a snapshot of this in action:
After updating:
Confirmed this doesn't interfere with clicking on any other elements after updating a password. Other nav items work as expected.